Skip to content

[stdlib] Fix assertionFailure() not respecting -assert-config Release at -Onone #85473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[stdlib] Fix assertionFailure() not respecting -assert-config Release at -Onone #85473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40c838
Fix assertionFailure() not respecting -assert-config Release at -Onone
realrajaryan Nov 13, 2025
fcc1c96
update test to expect the new, changed behavior
realrajaryan Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions stdlib/public/core/Assert.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,7 @@ public func precondition(
/// where `assertionFailure(_:file:line:)` is called.
/// - line: The line number to print along with `message`. The default is the
/// line number where `assertionFailure(_:file:line:)` is called.
@inlinable
@inline(__always)
@_transparent
#if $Embedded
@_disfavoredOverload
#endif
Expand All @@ -182,8 +181,7 @@ public func assertionFailure(
}

#if $Embedded
@inlinable
@inline(__always)
@_transparent
public func assertionFailure(
_ message: @autoclosure () -> StaticString = StaticString(),
file: StaticString = #file, line: UInt = #line
Expand Down
9 changes: 6 additions & 3 deletions validation-test/stdlib/AssertDiagnosticsSIL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
// RUN: %target-swift-frontend %s -emit-sil -verify

func assertionFailure_isNotNoreturn() -> Int {
_ = 0 // Don't implicitly return the assertionFailure call.
// assertionFailure() is now @_transparent (previously @inlinable), so the
// compiler can see that it never returns, eliminating the "missing return" error.
func assertionFailure_isNoreturn() -> Int {
_ = 0
assertionFailure("")
} // expected-error {{missing return in global function expected to return 'Int'}}
// No error expected - assertionFailure() is recognized as Never-returning
}