build: explicitly error out if -print-target-info fails
#85467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than trying to silently continue, catch an execution error and report it to the user. There is no possible recovery at this point.
compnerd
requested review from
edymtt,
etcwilde and
justice-adams-apple
as code owners
Member
Author
|
@swift-ci please smoke test |
etcwilde
reviewed
Nov 13, 2025
| endif() | ||
| execute_process(COMMAND ${module_triple_command} OUTPUT_VARIABLE target_info_json) | ||
| execute_process(COMMAND ${module_triple_command} | ||
| OUTPUT_VARIABLE target_info_json |
Member
There was a problem hiding this comment.
While we're improving the failure path, can we also get the ERROR_VARIABLE and output what the error was, either in the CONFIGURE_LOG or as part of the fatal error if it exists.
| execute_process(COMMAND ${module_triple_command} OUTPUT_VARIABLE target_info_json) | ||
| execute_process(COMMAND ${module_triple_command} | ||
| OUTPUT_VARIABLE target_info_json | ||
| RESULT_VARIABLE lastexitcode) |
Member
There was a problem hiding this comment.
nit, but not a huge fan of carcrashcase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than trying to silently continue, catch an execution error and report it to the user. There is no possible recovery at this point.