[ClangImporter] Undo changes around createClangInvocation (followup to #85445) #85457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…swiftlang#85445) Feedback in swiftlang#85445 after it merged pointed out that the changes around `createClangInvocation` are not necessary because `CompilerInvocation` do not hold a reference to `clang::DiagnosticOptions`, only the `clang::driver::Driver` does. These changes undo the modifications done there and return the code to the previous state (but keeps the changes around `createClangDriver` which was causing the use-after-free).
drodriguez
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
jansvoboda11
approved these changes
Nov 12, 2025
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback in #85445 after it merged pointed out that the changes around
createClangInvocationare not necessary becauseCompilerInvocationdo not hold a reference toclang::DiagnosticOptions, only theclang::driver::Driverdoes.These changes undo the modifications done there and return the code to the previous state (but keeps the changes around
createClangDriverwhich was causing the use-after-free).