[CSOptimizer] MemberImportVisibility: Don't consider overloads that c… #79004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
tshortli
reviewed
Jan 29, 2025
tshortli
approved these changes
Jan 29, 2025
Contributor
|
The source compatibility suite failures are unrelated. I've fixed them here: swift-server/async-http-client#804 |
…ome from implicit imports Ignore declarations that come from implicitly imported modules when `MemberImportVisibility` feature is enabled otherwise we might end up favoring an overload that would be diagnosed as unavailable later. Resolves: rdar://143582881
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ome from implicit imports
Ignore declarations that come from implicitly imported modules when
MemberImportVisibilityfeature is enabled otherwise we might end up favoring an overload that would be diagnosed as unavailable later.
Resolves: rdar://143582881