Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ public func globalCallMeLongBinaryOperator(run: (Int64, Int64) -> Int64) -> Int6
run(1, 2)
}

public func globalCallMeDoubleBinaryOperator(run: (Double, Double) -> Double) -> Double {
run(1.0, 2.0)
}

// ==== Internal helpers

func p(_ msg: String, file: String = #fileID, line: UInt = #line, function: String = #function) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,10 @@ void call_globalCallMeLongBinaryOperator_noThrow() {
long result = MySwiftLibrary.globalCallMeLongBinaryOperator((long a, long b) -> { return a + b; });
assertEquals(3L, result);
}

@Test
void call_globalCallMeDoubleBinaryOperator_noThrow() {
double result = MySwiftLibrary.globalCallMeDoubleBinaryOperator((double a, double b) -> { return a + b; });
assertEquals(3.0, result);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ public func globalCallMeLongBinaryOperator(run: (Int64, Int64) -> Int64) -> Int6
run(1, 2)
}

public func globalCallMeDoubleBinaryOperator(run: (Double, Double) -> Double) -> Double {
run(1.0, 2.0)
}

public func globalReceiveRawBuffer(buf: UnsafeRawBufferPointer) -> Int {
buf.count
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,10 @@ void call_globalCallMeLongBinaryOperator_noThrow() {
long result = MySwiftLibrary.globalCallMeLongBinaryOperator((long a, long b) -> { return a + b; });
assertEquals(3L, result);
}

@Test
void call_globalCallMeDoubleBinaryOperator_noThrow() {
double result = MySwiftLibrary.globalCallMeDoubleBinaryOperator((double a, double b) -> { return a + b; });
assertEquals(3.0, result);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ public func globalCallMeLongBinaryOperator(run: (Int64, Int64) -> Int64) -> Int6
run(1, 2)
}

public func globalCallMeDoubleBinaryOperator(run: (Double, Double) -> Double) -> Double {
run(1.0, 2.0)
}

public func closureMultipleArguments(
input1: Int64,
input2: Int64,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,10 @@ void globalCallMeLongBinaryOperator() {
long result = MySwiftLibrary.globalCallMeLongBinaryOperator((long a, long b) -> { return a + b; });
assertEquals(3L, result);
}

@Test
void globalCallMeDoubleBinaryOperator() {
double result = MySwiftLibrary.globalCallMeDoubleBinaryOperator((double a, double b) -> { return a + b; });
assertEquals(3.0, result);
}
}
4 changes: 4 additions & 0 deletions Sources/ExampleSwiftLibrary/MySwiftLibrary.swift
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ public func globalCallMeLongBinaryOperator(run: (Int64, Int64) -> Int64) -> Int6
run(1, 2)
}

public func globalCallMeDoubleBinaryOperator(run: (Double, Double) -> Double) -> Double {
run(1.0, 2.0)
}

public func globalReceiveRawBuffer(buf: UnsafeRawBufferPointer) -> Int {
buf.count
}
Expand Down
5 changes: 5 additions & 0 deletions Sources/JExtractSwiftLib/JavaTypes/JavaType+JDK.swift
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ extension JavaType {
.class(package: "java.util.function", name: "LongBinaryOperator")
}

/// The description of the type java.util.function.DoubleBinaryOperator.
static var javaUtilFunctionDoubleBinaryOperator: JavaType {
.class(package: "java.util.function", name: "DoubleBinaryOperator")
}

/// The description of the type java.lang.Class.
static var javaLangClass: JavaType {
.class(package: "java.lang", name: "Class")
Expand Down
10 changes: 10 additions & 0 deletions Sources/JExtractSwiftLib/KnownFunctionalInterfaces.swift
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ struct KnownJavaFunctionalInterface: Sendable {
result: .long
)

static let doubleBinaryOperator = KnownJavaFunctionalInterface(
JavaType.javaUtilFunctionDoubleBinaryOperator,
method: "applyAsDouble",
parameters: [.double, .double],
result: .double
)

static let all: [KnownJavaFunctionalInterface] = [
.runnable,
.booleanSupplier,
Expand All @@ -127,6 +134,7 @@ struct KnownJavaFunctionalInterface: Sendable {
.doublePredicate,
.intBinaryOperator,
.longBinaryOperator,
.doubleBinaryOperator,
]

static func find(parameters: [JavaType], result: JavaType) -> KnownJavaFunctionalInterface? {
Expand Down Expand Up @@ -209,6 +217,8 @@ struct KnownJavaFunctionalInterface: Sendable {
intBinaryOperator
case _ where parameter.isInt64:
longBinaryOperator
case _ where parameter.isDouble:
doubleBinaryOperator
default:
nil
}
Expand Down
44 changes: 44 additions & 0 deletions Tests/JExtractSwiftTests/FuncCallbackImportTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ final class FuncCallbackImportTests {

public func callMeIntBinaryOperator(callback: (Int32, Int32) -> Int32)
public func callMeLongBinaryOperator(callback: (Int64, Int64) -> Int64)
public func callMeDoubleBinaryOperator(callback: (Double, Double) -> Double)

public func callMeMore(callback: (UnsafeRawPointer, Float) -> Int, fn: () -> ())
public func withBuffer(body: (UnsafeRawBufferPointer) -> Int)
Expand Down Expand Up @@ -806,6 +807,49 @@ final class FuncCallbackImportTests {
)
}

@Test("Import: public func callMecallMeDoubleBinaryOperatorFunc(callback: (Double, Double) -> Double)")
func func_callMecallMeDoubleBinaryOperatorFunc_callback() throws {
var config = Configuration()
config.swiftModule = "__FakeModule"
let st = makeSwiftJavaAnalyzer(config: config)
st.log.logLevel = .error

try st.analyze(path: "Fake.swift", text: Self.class_interfaceFile)

let funcDecl = st.extractedGlobalFuncs.first { $0.name == "callMeDoubleBinaryOperator" }!

let generator = FFMSwift2JavaGenerator(
config: config,
translator: st,
javaPackage: "com.example.swift",
swiftOutputDirectory: "/fake",
javaOutputDirectory: "/fake"
)

let output = JavaPrinter.toString { printer in
generator.printFunctionDowncallMethods(&printer, funcDecl)
}

assertOutput(
output,
expectedChunks: [
"""
/**
* Downcall to Swift:
* {@snippet lang=swift :
* public func callMeDoubleBinaryOperator(callback: (Double, Double) -> Double)
* }
*/
public static void callMeDoubleBinaryOperator(java.util.function.DoubleBinaryOperator callback) {
try(var arena$ = Arena.ofConfined()) {
swiftjava___FakeModule_callMeDoubleBinaryOperator_callback.call(callMeDoubleBinaryOperator.$toUpcallStub(callback, arena$));
}
}
"""
]
)
}

@Test("Import: public func withBuffer(body: (UnsafeRawBufferPointer) -> Int)")
func func_withBuffer_body() throws {
var config = Configuration()
Expand Down
51 changes: 51 additions & 0 deletions Tests/JExtractSwiftTests/JNI/JNIClosureTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ struct JNIClosureTests {

public func closureIntBinaryOperator(closure: (Int32, Int32) -> Int32) {}
public func closureLongBinaryOperator(closure: (Int64, Int64) -> Int64) {}
public func closureDoubleBinaryOperator(closure: (Double, Double) -> Double) {}

public func closureWithArgumentsAndReturn(closure: (Int64, Bool) -> Int64) {}
"""
Expand Down Expand Up @@ -364,6 +365,31 @@ struct JNIClosureTests {
)
}

@Test
func closureDoubleBinaryOperator_javaBindings() throws {
try assertOutput(
input: source,
.jni,
.java,
expectedChunks: [
"""
/**
* Downcall to Swift:
* {@snippet lang=swift :
* public func closureDoubleBinaryOperator(closure: (Double, Double) -> Double)
* }
*/
public static void closureDoubleBinaryOperator(java.util.function.DoubleBinaryOperator closure) {
SwiftModule.$closureDoubleBinaryOperator(closure);
}
""",
"""
private static native void $closureDoubleBinaryOperator(java.util.function.DoubleBinaryOperator closure);
""",
]
)
}

@Test
func emptyClosure_swiftThunks() throws {
try assertOutput(
Expand Down Expand Up @@ -689,6 +715,31 @@ struct JNIClosureTests {
)
}

@Test
func closureDoubleBinaryOperator_swiftThunks() throws {
try assertOutput(
input: source,
.jni,
.swift,
detectChunkByInitialLines: 1,
expectedChunks: [
"""
@_cdecl("Java_com_example_swift_SwiftModule__00024closureDoubleBinaryOperator__Ljava_util_function_DoubleBinaryOperator_2")
public func Java_com_example_swift_SwiftModule__00024closureDoubleBinaryOperator__Ljava_util_function_DoubleBinaryOperator_2(environment: UnsafeMutablePointer<JNIEnv?>!, thisClass: jclass, closure: jobject?) {
SwiftModule.closureDoubleBinaryOperator(closure: {
let class$ = environment.interface.GetObjectClass(environment, closure)
let methodID$ = environment.interface.GetMethodID(environment, class$, "applyAsDouble", "(DD)D")!
environment.interface.DeleteLocalRef(environment, class$)
let arguments$: [jvalue] = [_0.getJValue(in: environment), _1.getJValue(in: environment)]
return Double(fromJNI: environment.interface.CallDoubleMethodA(environment, closure, methodID$, arguments$), in: environment)
}
)
}
"""
]
)
}

@Test
func closureWithArgumentsAndReturn_javaBindings() throws {
try assertOutput(
Expand Down
Loading