Remove DSLNode-based implementation#857
Merged
natecook1000 merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
natecook1000
force-pushed
the
remove-old-dslnode
branch
2 times, most recently
from
a9693f6 to
4ca54ce
Compare
Member
Author
|
@swift-ci Please test Linux platform |
The recursive DSLTree approach required nodes nested in nodes. The DSLTree implementation flattened this tree, but didn't remove the nested nodes, instead replacing them with placeholder entries that were unused, in order to reduce the code change. This change completes the transition, modifying the nodes to no longer store their children. With this change, we can also remove a significant amount of unused code. The change includes some expanded test coverage of the RegexBuilder syntax conversion, as well. Note that even though `DSLTree.Node` no longer requires declaration as `indirect`, compilation times are worsened if we remove the indirection.
natecook1000
force-pushed
the
remove-old-dslnode
branch
from
4ca54ce to
d12908f
Compare
stephentyrone
approved these changes
Apr 10, 2026
parkera
approved these changes
Apr 15, 2026
|
@swift-ci test |
This restores the original scalar spelling of literal patterns when converting to RegexBuilder syntax.
Member
Author
|
@swift-ci Please test Linux platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recursive DSLTree approach required nodes nested in nodes. The DSLTree implementation flattened this tree, but didn't remove the nested nodes, instead replacing them with placeholder entries that were unused, in order to reduce the code change. This change completes the transition, modifying the nodes to no longer store their children.
With this change, we can also eliminate the indirection in the nodes, and remove a significant amount of unused code. The change includes some expanded test coverage of the RegexBuilder syntax conversion, as well.