-
Notifications
You must be signed in to change notification settings - Fork 76
Improve Integrate with Zephyr doc #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rauhul
merged 6 commits into
swiftlang:main
from
xtremekforever:feature/improve-zephyr-doc
Jun 21, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d693da
Update architectures and flags for Zephyr guide
xtremekforever 3708503
Added back picolibc include dir, added more info
xtremekforever 3935459
Add more information on linking customizations
xtremekforever 3139ef7
Change title of IntegrateWithZephyr doc
xtremekforever 9446085
Merge branch 'main' into feature/improve-zephyr-doc
xtremekforever 2523255
Merge branch 'main' into feature/improve-zephyr-doc
xtremekforever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this imply you should be using -fshort-enums?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well even if you use -fshort-enums in your main Xcc flags, these warnings get printed as soon as you pull in swiftUnicodeDataTables. Could be that somehow the tables are compiled different (like without -fshort-enums) or some other reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting. Regardless, this is a great improvement and we should look into the enum thing independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind rebasing and ill run ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should open a ticket on swiftlang/swift for this enum mismatch for armv7em? Or just let it be...
Yes I'll rebase in a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should just build unicode support as part of the SwiftPM/CMake build graph and avoid prebuilts