SwiftDriver: explicitly select RSP handling on Windows #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling from Windows to Android, if we spill past the command line limit, we would need to emit a response file. The response file is emitted into the style of the build rather than the host. This means that on Unix platforms, we need to indicate that the response file is Windows not Unix. We rely on the internal behaviour of the second flag being special cased and emit the `--rsp-quoting=windows` parameter in the second argument position to ensure that it is passed on the command line (as if the argument is pushed into the response file, it will not be possible to honour it for processing the file).
Member
Author
|
@swift-ci please test |
Member
Author
|
This should help repair the nightlies on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling from Windows to Android, if we spill past the command line limit, we would need to emit a response file. The response file is emitted into the style of the build rather than the host. This means that on Unix platforms, we need to indicate that the response file is Windows not Unix.
We rely on the internal behaviour of the second flag being special cased and emit the
--rsp-quoting=windowsparameter in the second argument position to ensure that it is passed on the command line (as if the argument is pushed into the response file, it will not be possible to honour it for processing the file).