Rename two internal targets for clarity (with a common prefix) #1345
+193
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm tentatively trying a different target name in swiftlang/swift#84510 (comment) |
1 task
Contributor
Author
|
@swift-ci please test |
d-ronnqvist
changed the title
Contributor
Author
|
The cross-repo tests, passed here https://ci.swift.org/job/swift-PR-Linux/24867/ so these names (with the "DocC" prefix) don't collide with anything (not that surprising) |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
I'll run one last cross-repo there swiftlang/swift#84510 (comment) before merging this just to make ensure that it doesn't break the Windows CI—which I have no other way to verify currently. |
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1342 and adds a "DocC" prefix to targets so that they don't conflict with other packages in the toolchain