Skip to content

[6.3][ScanDaemon] unlock pid file first before unlink socket #11831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: swift/release/6.3
Choose a base branch
from
Open

[6.3][ScanDaemon] unlock pid file first before unlink socket #11831

wants to merge 1 commit into from

Conversation

@cachemeifyoucan
Copy link

@cachemeifyoucan cachemeifyoucan commented Nov 14, 2025 •
edited
Loading

  • Explanation: Fix a potential issue that can cause new clang scan daemon failed to start when the previous daemon timed out at the same time. It is possible for the timed out daemon still hold pid file when being shutdown, when the new clang daemon is starting up and failed to lock the pid file. To the new clang daemon, this is indistinguishable from losing the race to start a new daemon with another clang invocation, thus the new starting request will be dropped and no daemon will be started.
  • Scope: Affects clang cache build that uses daemon to integrate with legacy build systems.
  • Issues:
  • Original PRs: [ScanDaemon] unlock pid file first before unlink socket #11817
  • Risk: Low. caching build with daemon only and fixes a race condition.
  • Testing: N/A
  • Reviewers: @benlangmuir

@cachemeifyoucan
[ScanDaemon] unlock pid file first before unlink socket
c08a57c 
Fix a potential issue that can cause new clang scan daemon failed to
start when the previous daemon timed out at the same time. It is
possible for the timed out daemon still hold pid file when being
shutdown, when the new clang daemon is starting up and failed to lock
the pid file. To the new clang daemon, this is indistinguishable from
losing the race to start a new daemon with another clang invocation,
thus the new starting request will be dropped and no daemon will be
started.

(cherry picked from commit 5595098)
@cachemeifyoucan cachemeifyoucan changed the title [ScanDaemon] unlock pid file first before unlink socket [6.3][ScanDaemon] unlock pid file first before unlink socket Nov 14, 2025
@cachemeifyoucan cachemeifyoucan requested a review from a team November 14, 2025 21:49
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Nov 14, 2025

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cachemeifyoucan