Skip to content

Conversation

@qiongsiwu
Copy link

llvm#164345 merge conflict resolution with next introduced two issues.

  1. It did not correctly pick up the logic to set StableDir for CompilerInstanceWithContext.
  2. It did not correctly setup the action controller for CAS.

This PR fixes both issues.

@qiongsiwu
Copy link
Author

We have tests in swift that catch these two bugs, but I don't think we have any in next. I can look into adding some test cases if that is desired.

@qiongsiwu
Copy link
Author

@swift-ci please test llvm

@qiongsiwu
Copy link
Author

The two failing tests were failing already before this PR.

Failed Tests (2):
    Clang :: Sema/attr-counted-by-void-ptr-gnu.c
    LLVM :: tools/dsymutil/ARM/cas-gmodule.test

Copy link

@jansvoboda11 jansvoboda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add a test for these. I understand that the missing call to createActionController() didn't cause a test failure - you probably need a new test for this with CAS and by-name scan. But the StableDirs being a local instead of member now surprises me, that should definitely trigger some existing (upstream) test in LLVM, no?

@qiongsiwu
Copy link
Author

@swift-ci please test llvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants