fix: improve demo experience by sacrosanctic · Pull Request #1203 · sveltejs/cli

sacrosanctic · 2026-07-30T17:30:31Z

Description

Reopened from #1188 due to a glitch.

Checklist

Update snapshots (if applicable)
Add a changeset (if applicable)
Allow maintainers to edit this PR
I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

* main * throw if pm isnt installed * throw * nit * changeset * tmv sv ordering * sh is unknwon on windows (execSync know about it) * hint to label & next step * caching agent install, keep none by default --------- Co-authored-by: jycouet <jycouet@gmail.com>

Bump package-manager-detector to ^1.8.0, the first release with nub in its agent and command tables. sv-utils bundles the library at build time, so the published bundle only knows about nub once rebuilt against >=1.8.0.

…eltejs#1192) When prettier is among the scaffolded add-ons, format the whole project rather than only the add-on-touched files, so a fresh project passes its own lint. Prettier's ignore rules still apply. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>

* feat: addOption in setup phase * fmt² * okay cut * humm * fmt * chore: update api surface * test: await async setupAddons in engine tests * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * Update packages/sv/src/core/config.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * feat: typesafe addOption keys via defineAddon setup generic - addOption now constrains key + question type from defineAddon<SetupValues>() - regenerate api surface --------- Co-authored-by: Scott Wu <sw@scottwu.ca>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* mv * feat: welcome `ai-tools` * abc * don't format skills * opencode -> plugin, claude question, subagents * fmt * cleanup snap * snap * update new path * feat(ai-tools): choose Svelte plugin or individual tools per client - delivery option: Svelte plugin (Claude via committed .claude/settings.json, opencode via opencode.json) or individual tools - granular MCP/skills/sub-agents selection; rename `setup` -> `mcpSetup` - consolidate per-client config into a single `CLIENTS` registry * feat(ai-tools): install skills for cursor, gemini and vscode * feat(ai-tools): CLAUDE.md imports AGENTS.md to keep a single source of truth * chore(ai-tools): rename RX_MD to REGEX_MD * feat(ai-tools): warn in next steps when plugin and loose skill/agent files coexist * fmt * fix(ai-tools): 'other' client now writes AGENTS.md * fix(ai-tools): only ask tool/MCP questions when a client can use them * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update documentation/docs/30-add-ons/01-ai-tools.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+skills/svelte-code-writer/SKILL.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/addons/ai-tools.ts Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * Update packages/sv/src/create/shared/+agents/svelte-file-editor.md Co-authored-by: Rich Harris <hello@rich-harris.dev> * update skills * fix: drop stale reference files and update ai-tools snapshots --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>

…rrors (sveltejs#1198) * fix: drop obsolete pnpm allowBuilds entries and surface real format errors * test: install generated project outside the repo workspace

…t 3 shape (sveltejs#1199) * feat(sv-utils): add SvelteKit 3 helpers Version detection, the `$lib` -> `#lib` move and the generated `$app/tsconfig`, so add-ons stop hardcoding kit-version-specific shapes. * fix(core): make `runsAfter` actually order add-ons It sorted by number of constraints, so an add-on could still run before one it declared it runs after. Topologically sort instead, seeded with the previous order so unconstrained add-ons keep their relative position. * fix(experimental): create manages `#lib` and the rest of the SvelteKit 3 shape - skip `handleRenderingErrors`/`explicitEnvironmentVariables`, removed in kit 3 - extend `$app/tsconfig` and own `include`, keeping deliberate compiler option overrides - rewrite `$lib` to `#lib` and declare the subpath imports Vite resolves from - drizzle drops the removed `typescript.config` hook; `defineEnvVars` moves to `@sveltejs/kit/env` - better-auth and paraglide emit the right lib prefix and route type * test(cli): cover `kit@next` with a real install, build and check No snapshot: the point is that the project works, not what it looks like. * Update packages/sv/src/addons/drizzle.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * Update packages/sv-utils/src/kit3.ts Co-authored-by: Scott Wu <sw@scottwu.ca> * test(cli): cover better-auth on `kit@next`, finish the `KIT3_TSCONFIG_DEFAULT` rename better-auth has the most `#lib` imports, so it gets its own `kit@next` install/build/check case. It can't join the existing one: kit treats any `remote.js` as a remote module, including the one `jose` ships, so `remoteFunctions` breaks the build. Also rewords the changeset and updates the two remaining `KIT3_TSCONFIG_INHERITED` references. * test(cli): pin the `kit@next` prereleases the experimental cases run against * test(cli): drop the better-auth `kit@next` case * chore: fix indentation * test(cli): let the generated project install a fresh prerelease * test(cli): track the `next` tag instead of a pinned prerelease * chore: trim the changesets to one line each * chore: changeset wording --------- Co-authored-by: Scott Wu <sw@scottwu.ca>

pkg-svelte-dev · 2026-07-30T17:30:33Z

Install the latest version of sv from b91b66c:

pnx https://pkg.svelte.dev/sv/c/b91b66c0049a2fea3da98701b50d8dfdee4cce52 create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1203

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

changeset-bot · 2026-07-30T17:30:35Z

⚠️ No Changeset found

Latest commit: b91b66c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sacrosanctic · 2026-07-30T20:41:26Z

 		],
-		required: false
+		required: false,
+		condition: ({ template }) => template !== 'demo'


@jycouet the general idea of this PR is this, thoughts?

I find it strange to not allow better-auth demo in demo template

The logic got lost during the rebasing. It's supposed to be "when template is demo, don't ask, always use template"

The logic got lost during the rebasing. It's supposed to be "when template is demo, don't ask, always use template"

I guess you meant when template is demo, don't ask, always use demo ?
I don't really see the value there and it's doing a big breaking, and it's only for create.

jycouet

All in all, I'm not a big fan.

I re read the issue a few times, and:

On the demo template, add a fourth header called addon which links to the /demo page.

It could also be /demo as a 4th tab?

Actually, in the minimal template, I would love to have a link to the demo page from the root layout! (It's maybe VERY intrusive... but very visible for people adding something in their app!)

when sv create, addons should not prompt to add demo if the template is demo

I think that this is not necessary. Why doing "soooo much work" for so small outcome? Maybe I'm missing somehting?

rename /demo to /addon

Possible yes, but I don't really see the cool thing about it

sacrosanctic · 2026-07-31T20:11:46Z

changes:

removed the breaking change by making it additive
/addon back to /demo

Overall, the cumulative diff has been reduced so its easier to see the intent. I think less prompting is better. Especially when it comes to demos, which is used by new users. And it's a redundant question.

api changes

Regardless of this PR, I do think we should have access to template from within the addon
widening of type for svelte.addFragment

sacrosanctic · 2026-08-15T02:23:31Z

const demo = createDemoPage('paraglide', language, directory.kitRoutes);
sv.file(...demo.listing);
sv.file(...demo.header);

Im also interested in making this a sv-utils so the community can easily add their demo to the demopage.

sacrosanctic · 2026-08-15T02:29:58Z

I would like this merged if a maintainer can provide some more feedback.

jycouet

I'm not a big fan of this new template param that is available only in create scenario.
And I don't see the value of skipping demo questions in the demo template.
Am I missing something?

jycouet · 2026-08-15T05:42:38Z

+		const demoPassword = template === 'demo' || options.demo?.includes('password');
+		const demoGithub = template === 'demo' || options.demo?.includes('github');
 		const hasDemo = demoPassword || demoGithub;


Why forcing the password demo and the github demo in the demo template?

We should prompt the user instead of forcing.

sacrosanctic · 2026-08-15T11:41:33Z

I'm not a big fan of this new template param that is available only in create scenario.

Originally tried dynamic options but didn't work. sv create is the only time template value is valid, there's no template in sv add

And I don't see the value of skipping demo questions in the demo template.

What is the value of asking? If you select demo template and addons that has demos, you want a playground to mess around with.

	want demos	dont want demos
demo template	new users	who
minimal template	tryout addon	experienced users

jycouet · 2026-08-15T22:36:11Z

And I don't see the value of skipping demo questions in the demo template.

What is the value of asking? If you select demo template and addons that has demos, you want a playground to mess around with.

want demos dont want demos
demo template new users who
minimal template tryout addon experienced users

maybe a new user want to know only the code about password and not github.
I like to not have too many hidden if in addon. To avoid "I ran this add-on but now it not behaving the same, why?"
With your matrix, you are guessing what question to ask depending on "user level". I think that it's too much guessing over predictability.

sacrosanctic

I see where you're coming from. On the other side, it feels like you're getting asked the same question again.
"Which template do you want?" "Demo" "Do you want to include a demo?" "Didnt i just answer this question?"

I have reversed the changes to complex questions. We only skip questions that are binary like 'Do you want to include a demo?'. If you remain unconvinced, then we can move on.

sacrosanctic and others added 9 commits July 23, 2026 15:46

fix: recognize the nub package manager (sveltejs#1187)

580c2f7

Bump package-manager-detector to ^1.8.0, the first release with nub in its agent and command tables. sv-utils bundles the library at build time, so the published bundle only knows about nub once rebuilt against >=1.8.0.

Version Packages (sveltejs#1191)

063258f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: drop obsolete pnpm allowBuilds entries and surface real format e…

9b3fa17

…rrors (sveltejs#1198) * fix: drop obsolete pnpm allowBuilds entries and surface real format errors * test: install generated project outside the repo workspace

init

aed2b78

sacrosanctic added 6 commits July 31, 2026 03:25

.

3146816

fix

6fca04d

make spreadable

3441e5a

update snapshots

9814bda

fix

619f598

fix

208fd30

sacrosanctic changed the title ~~fix: improve demo experience- #1188~~ fix: improve demo experience Jul 30, 2026

sacrosanctic added 4 commits July 31, 2026 04:07

lint

14c3984

fix

177e03d

fix tests

ab022e3

go

0b79628

sacrosanctic commented Jul 30, 2026

View reviewed changes

sacrosanctic marked this pull request as ready for review July 31, 2026 02:53

jycouet reviewed Jul 31, 2026

View reviewed changes

Comment thread packages/sv/src/addons/tests/better-auth/test.ts Outdated

Comment thread packages/sv/src/core/options.ts Outdated

sacrosanctic added 2 commits July 31, 2026 23:19

autofill

5984745

remove breaking change

03d4cef

sacrosanctic force-pushed the unpleasant-orca branch from 621319f to 6624f6a Compare July 31, 2026 19:47

sacrosanctic added 2 commits August 1, 2026 03:51

back to /demo

46e8818

clean up

8d09fc0

sacrosanctic force-pushed the unpleasant-orca branch from 6624f6a to e9d82d0 Compare July 31, 2026 19:52

sacrosanctic added 2 commits August 1, 2026 04:02

fix

f8f75a2

snapshot

e1892a4

sacrosanctic force-pushed the unpleasant-orca branch from f17c98a to e1892a4 Compare July 31, 2026 20:03

missed a spot

adf26ee

manuel3108 changed the base branch from main to version-1 August 7, 2026 08:51

sacrosanctic added 3 commits August 9, 2026 14:25

Merge remote-tracking branch 'upstream/version-1' into unpleasant-orca

890ccc3

Merge remote-tracking branch 'upstream/version-1' into unpleasant-orca

be348f6

fixes

8de0189

sacrosanctic force-pushed the unpleasant-orca branch from 9f9fe66 to 8de0189 Compare August 9, 2026 06:46

sacrosanctic added 3 commits August 9, 2026 14:47

.

08244eb

Merge remote-tracking branch 'upstream/version-1' into unpleasant-orca

c5781d0

Merge remote-tracking branch 'upstream/version-1' into unpleasant-orca

182e514

sacrosanctic added 2 commits August 15, 2026 10:25

Merge remote-tracking branch 'upstream/version-1' into unpleasant-orca

6f47bd5

lint

a57b7d1

jycouet reviewed Aug 15, 2026

View reviewed changes

keep in complex questions

b91b66c

sacrosanctic commented Aug 16, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

sacrosanctic commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

pkg-svelte-dev Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

sacrosanctic Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

jycouet Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jycouet Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

jycouet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sacrosanctic commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sacrosanctic commented Aug 15, 2026

Uh oh!

sacrosanctic commented Aug 15, 2026

Uh oh!

jycouet left a comment

Choose a reason for hiding this comment

Uh oh!

jycouet Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

sacrosanctic Aug 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sacrosanctic commented Aug 15, 2026

Uh oh!

jycouet commented Aug 15, 2026

Uh oh!

sacrosanctic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sacrosanctic commented Jul 30, 2026 •

edited

Loading

pkg-svelte-dev Bot commented Jul 30, 2026 •

edited

Loading

changeset-bot Bot commented Jul 30, 2026 •

edited

Loading

sacrosanctic commented Jul 31, 2026 •

edited

Loading