fix: bump declared minimum macOS deployment target to 10.15#477
Open
tsushanth wants to merge 1 commit into
Open
fix: bump declared minimum macOS deployment target to 10.15#477tsushanth wants to merge 1 commit into
tsushanth wants to merge 1 commit into
Conversation
Package.swift declared `.macOS(.v10_12)` but the SDK uses Combine, async/await, Task, and UnsafeContinuation throughout — all of which require macOS 10.15+. The declaration was vestigial; no real consumer could ever have built against Superwall on 10.12. Bumping the declared minimum so SwiftPM rejects the integration with a clear deployment-target diagnostic at resolve time, rather than letting it through and producing dozens of "is only available in macOS 10.15 or newer" errors deep in Superscript and SuperwallKit sources. Fixes superwall#317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Why
Closes #317.
`Package.swift` declared `.macOS(.v10_12)` but every macOS-relevant file in the SDK uses Combine, async/await, `Task`, or `UnsafeContinuation` — all of which require macOS 10.15+. There are 651 references to those features across `Sources/SuperwallKit/`.
The 10.12 declaration was never realistic. The issue reporter (and anyone else integrating Superwall into a Mac Catalyst target) hit it as a wall of "is only available in macOS 10.15 or newer" errors deep in Superscript and SuperwallKit source files.
What
Single-character bump in `Package.swift` (`v10_12` → `v10_15`) plus a CHANGELOG entry framed as a fix (deployment-target diagnostics now surface honestly at resolve time instead of failing late in compile).
Podspec is unaffected — `SuperwallKit.podspec` only declares iOS.
Scope
Doesn't change `.iOS(.v13)` or `.watchOS("6.2")`. Doesn't bump SDK version (deliberately tagged `Unreleased` in CHANGELOG — let you decide whether this rides in the next patch or a minor).
Greptile Summary
Bumps the declared minimum macOS deployment target in
Package.swiftfrom10.12to10.15, aligning the package manifest with what the SDK's source code actually requires (Combine,async/await,Task,UnsafeContinuation). A matching CHANGELOG entry is added underUnreleased.Package.swift: single character change —.macOS(.v10_12)→.macOS(.v10_15).CHANGELOG.md: newUnreleased / Fixesbullet explaining the change and the Mac Catalyst integration problem it resolves.Confidence Score: 5/5
Safe to merge — the change is a one-line manifest correction that makes the declared platform requirement honest; no runtime behaviour is altered.
The only touched files are
Package.swift(one character changed in a platform version string) andCHANGELOG.md. The new value10.15is the correct minimum for Combine and Swift Concurrency back-deployment, matching what the SDK source already requires. No Swift source, no tests, no public API, and no podspec are affected.No files require special attention.
Important Files Changed
.macOS(.v10_12)to.macOS(.v10_15), correctly aligning the declared minimum with the actual Combine/Swift Concurrency requirements of the SDK source.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Integrator adds SuperwallKit\nto Mac Catalyst target] --> B{SPM resolves\nplatform constraints} B -- Before PR\n.macOS(.v10_12) --> C[Resolution succeeds\nwith wrong minimum] C --> D[Compiler hits Combine /\nasync-await unavailable errors\ndeep in SDK source] D --> E[❌ Confusing build failure\nat compile time] B -- After PR\n.macOS(.v10_15) --> F[Resolution correctly requires\nmacOS 10.15+] F --> G{Host target ≥ 10.15?} G -- Yes --> H[✅ Builds successfully] G -- No --> I[❌ Clear deployment-target\nerror at resolve time]Reviews (1): Last reviewed commit: "fix: bump declared minimum macOS deploym..." | Re-trigger Greptile