fix(openai-sdk): cap supermemory to <3.5 so a fresh install imports - #1236
fix(openai-sdk): cap supermemory to <3.5 so a fresh install imports#1236Cintu07 wants to merge 2 commits into
Conversation
supermemory 3.5+ renamed the types this SDK imports (MemoryAddResponse etc) and moved memories.add to the top-level client, so a plain pip install pulls a version where importing supermemory_openai raises ImportError. Cap to the 3.4.x line the package is tested against (uv.lock pins 3.4.0) until the SDK is migrated to the newer supermemory API.
|
still broken on pypi as of today. supermemory 3.51.0 shipped yesterday and to be clear, this pr needs no decision from you. it caps to the same 3.4.x the full migration to the newer api is worth doing, but it's a bigger change @Dhravya mind taking a look? small one. |
|
Looks good. Please bump supermemory-openai-sdk from 1.0.4 to 1.0.5 before merging, since 1.0.4 is already published on PyPI and cannot be replaced |
There was a problem hiding this comment.
✅ Ready to approve
The change is a small, targeted packaging constraint that directly prevents the documented import failure without affecting runtime code paths.
Note: this review does not count toward required approvals for merging.
Pull request overview
Updates the supermemory-openai-sdk Python package metadata to prevent fresh installs from pulling incompatible supermemory versions (>=3.5) that break imports due to upstream API/type renames.
Changes:
- Bump package version from
1.0.4to1.0.5. - Cap the
supermemorydependency to<3.5.0(while keeping>=3.1.0) to align with the known-working 3.4.x line.
File summaries
| File | Description |
|---|---|
| packages/openai-sdk-python/pyproject.toml | Bumps package version and constrains supermemory dependency to avoid importing against incompatible supermemory releases. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
done, bumped to 1.0.5 in 3f34afd. good to merge whenever you get a sec ^-^ |
|
the 1.0.5 bump staled the approval, mind re-approving when you get a sec? this one is the quick cap. i also opened the full migration to the 3.x api as the proper fix in #1427, so take whichever you prefer |
Fixes #1235
A fresh pip install supermemory-openai-sdk pulls the latest supermemory (3.50) and the package fails to import, because supermemory 3.5+ renamed the types it imports (MemoryAddResponse etc) and moved memories.add off client.memories.
The package's uv.lock already pins supermemory 3.4.0, which is what it actually works against, so this just caps the declared dependency to the same 3.4.x line. Confirmed a fresh install with the cap imports fine.
This is the minimal fix to unbreak installs. Happy to instead do the full migration to the newer 3.x API (client.add, AddResponse, etc.) if you'd rather go that route, just say the word