Fix settings organization flows#1159
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 50f1398 | Jun 24 2026, 02:21 PM |
|
Claude finished @ved015's task in 1m 29s —— View job Code Review Complete
Result: No issues found — this looks good to ship. ✓ The PR properly fixes dialog focus/state issues when switching orgs, simplifies org creation flow, and makes the org switcher scrollable. All timer cleanups, portal container usage, and error handling are correctly implemented. Score: 10/10 |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 50f1398 | Commit Preview URL Branch Preview URL |
Jun 24 2026, 02:23 PM |
There was a problem hiding this comment.
Overview: Fixes dialog focus/state issues when switching orgs in Settings, simplifies org creation by redirecting to onboarding, and makes the org switcher list scrollable.
Issues found: None — this looks good to ship.
The changes are well-structured:
- The
key={activeOrgId}on the Dialog properly resets state when switching orgs - Timer cleanup is handled correctly via refs and cleanup effects
- The
portalContainerprop correctly solves nested dialog focus issues by portaling the delete dialog inside the settings modal - The
document.body.style.pointerEvents = ""workaround for Radix's stuck pointer-events is appropriately placed - Scroll containment with
stopPropagationon wheel/touch events is the correct pattern for scrollable areas inside popovers - Error handling in onboarding properly shows toast and redirects existing users to dashboard on failure
Score: 10/10
| const MODAL_SURFACE_SHADOW = | ||
| "0 2.842px 14.211px 0 rgba(0,0,0,0.25), 0.711px 0.711px 0.711px 0 rgba(255,255,255,0.10) inset" | ||
|
|
||
| const INSET_SHADOW = "inset 1.313px 1.313px 3.938px rgba(0,0,0,0.7)" |
There was a problem hiding this comment.
why having these variables of css here?
Summary