Skip to content

Add Agents space for shared coding memories#1150

Open
ved015 wants to merge 2 commits into
mainfrom
feat/agents
Open

Add Agents space for shared coding memories#1150
ved015 wants to merge 2 commits into
mainfrom
feat/agents

Conversation

@ved015

@ved015 ved015 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Add an Agents section to the space selector.
  • Group shared repo-based Claude Code/Codex memories under Agents.
  • Hide duplicate Claude Code rows when an equivalent shared Agents row exists.
  • Keep Codex legacy spaces visible for migration.
  • Add Memories filters for Claude Code and Codex within Agents.
  • Use the Supermemory logo for the Agents icon.

@graphite-app graphite-app Bot requested a review from Dhravya June 22, 2026 12:31
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp f6c128a Jun 23 2026, 02:35 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app f6c128a Commit Preview URL

Branch Preview URL
Jun 23 2026, 02:37 AM

@claude

claude Bot commented Jun 22, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 1m 41s —— View job


Code Review Complete

  • Analyzing PR context
  • Fetching PR diff
  • Reading changed files for deeper context
  • Checking for bugs, security issues, and logic errors
  • Submitting review

Overview: Adds an "Agents" category to the space selector that groups shared repo-based Claude Code and Codex memories, with deduplication logic to hide redundant Claude Code rows when equivalent shared Agents rows exist.

Issues found: None — this looks good to ship.

The implementation is clean and well-structured:

  • detectAgentSpace() correctly identifies both repo_* container tags as shared repos and falls back to plugin detection for individual Claude Code/Codex spaces
  • The visibleSpaces deduplication logic properly normalizes project keys and filters Claude Code duplicates while preserving Codex spaces for migration
  • Query key updates include the new selectedAgentSource parameter, ensuring proper cache invalidation
  • Null/undefined handling is consistent throughout

Score: 10/10

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds an "Agents" category to the space selector that groups shared repo-based Claude Code and Codex memories, with deduplication logic to hide redundant Claude Code rows when equivalent shared Agents rows exist.

Issues found: None — this looks good to ship.

The implementation is clean and well-structured:

  • detectAgentSpace() correctly identifies both repo_* container tags as shared repos and falls back to plugin detection for individual Claude Code/Codex spaces
  • The visibleSpaces deduplication logic properly normalizes project keys and filters Claude Code duplicates while preserving Codex spaces for migration
  • Query key updates include the new selectedAgentSource parameter, ensuring proper cache invalidation
  • Null/undefined handling is consistent throughout (e.g., sourceFacets?.filter(...) ?? [])
  • Type narrowing in renderCategoryChip improves type safety without changing runtime behavior

Score: 10/10

Show workspace names in rows instead of repeating the category, add an
Agent space hint in All Spaces, and update the filter helper copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants