Skip to content

Add playground shortcut to space selector#1145

Open
ved015 wants to merge 2 commits into
mainfrom
feat/playground
Open

Add playground shortcut to space selector#1145
ved015 wants to merge 2 commits into
mainfrom
feat/playground

Conversation

@ved015

@ved015 ved015 commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a hover-only “Open in Playground” action to space rows in the Nova space selector.
  • Opens the console playground with the row’s full containerTag in the URL.
  • Keeps the action beside delete with a tooltip and avoids sticky focus after click.
nova_playground-1781964757600.1.mp4

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app b463239 Commit Preview URL

Branch Preview URL
Jun 20 2026, 02:18 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 20, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp b463239 Jun 20 2026, 02:17 PM

@graphite-app graphite-app Bot requested a review from Dhravya June 20, 2026 14:15
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown

Claude finished @ved015's task in 1m 11s —— View job


Reviewing PR #1145

  • Get PR diff and analyze changes
  • Read surrounding code for context
  • Check for existing review comments
  • Submit review with findings

Summary

Reviewed the changes to apps/web/components/select-spaces-modal.tsx. The implementation is clean and secure:

  • URL construction uses the proper URL API with searchParams.set() for safe encoding
  • window.open uses noopener,noreferrer for security
  • Event handling properly stops propagation and removes focus after click
  • Accessibility covered with aria-label and Tooltip
  • Previous dev URL issue has been fixed in the latest commit

Score: 10/10 — No bugs, security issues, or logic errors found. Good to ship.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a hover-only "Open in Playground" button to space rows in the Nova space selector that opens the console playground with the containerTag in the URL.

Issues found:

  • The hardcoded URL uses the dev environment (console.dev.supermemory.ai) instead of production (console.supermemory.ai). This will redirect production users to the dev environment.

Score: 8/10

The implementation is clean — proper event handling with stopPropagation(), correct use of noopener,noreferrer for external links, and safe URL construction with the URL API. Just needs the URL fix before merging.

Comment thread apps/web/components/select-spaces-modal.tsx

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a hover-only "Open in Playground" button to space rows in the space selector, opening the console playground with the space's containerTag.

Issues found: None — this looks good to ship.

The implementation is clean:

  • URL construction uses the proper URL API with searchParams.set() for safe encoding
  • window.open uses noopener,noreferrer for security
  • Event handling properly stops propagation and removes focus after click
  • Accessibility is covered with aria-label and Tooltip
  • Previous dev URL issue has been fixed (now correctly uses console.supermemory.ai)

Score: 10/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant