Skip to content

Show MCP connection status in integrations#1135

Open
ishaanxgupta wants to merge 5 commits into
mainfrom
fix/mcp-connected-integrations-ui
Open

Show MCP connection status in integrations#1135
ishaanxgupta wants to merge 5 commits into
mainfrom
fix/mcp-connected-integrations-ui

Conversation

@ishaanxgupta

@ishaanxgupta ishaanxgupta commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Parse enabled MCP OAuth API keys from the integrations page key list.
  • Show MCP as connected in MCP integration cards, the Active filter count, featured CTA, and active connections rail.
  • Reuse the existing MCP metadata signal used elsewhere in the app (sm_source: "mcp" or sm_kind: "mcp_oauth_exchange").
image

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 9286229 Jun 22 2026, 11:42 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 9286229 Commit Preview URL

Branch Preview URL
Jun 22 2026, 11:43 AM

Copy link
Copy Markdown
Contributor Author

Update after latest commit:

  • MCP connection state is now shown once in the MCP section header, before the carousel arrows, because the API does not return per-client MCP identity.
  • MCP client cards now use compact + actions instead of text Connect buttons.
  • The previous per-card MCP connected indicator was removed so all MCP clients are not shown as individually connected.

@ishaanxgupta ishaanxgupta marked this pull request as ready for review June 20, 2026 13:33
@graphite-app graphite-app Bot requested a review from Dhravya June 20, 2026 13:33
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown

Claude finished @ishaanxgupta's task in 53s —— View job


Claude finished @ishaanxgupta's task in 53s —— View job


Review Complete

  • Get the latest PR diff
  • Check if encoding bugs from previous review were fixed
  • Review for any other issues
  • Submit review summary

Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.

Issues found: None — the encoding bugs from previous reviews have all been fixed in the latest commits.

Score: 10/10

The code is clean and ready to ship:

  • isMcpAuthMetadata() correctly detects MCP keys using both metadata signals (sm_source: "mcp" or sm_kind: "mcp_oauth_exchange")
  • activeMcpKey memo properly finds the most recent key by comparing timestamps
  • All three encoding issues (··) have been fixed at lines 1098, 1511, and 1528
  • The McpRailRow component integrates cleanly with the existing rail entry system
  • Null/undefined cases are handled properly throughout

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.

Issues found:

  • Character encoding bug: Three instances of · instead of · (middle dot) at lines 1098, 1511, and 1528. This will display incorrectly in the UI.

Score: 8/10

The logic and structure look solid. The code correctly reuses the existing MCP metadata signals (sm_source: "mcp" or sm_kind: "mcp_oauth_exchange"), properly handles null/undefined cases, and integrates cleanly with the existing rail entry system. The activeMcpKey memo correctly finds the most recent key by comparing timestamps.

Fix the encoding issue and this is good to ship.

Comment thread apps/web/components/integrations-view.tsx Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds MCP connection status display to the integrations page by parsing MCP OAuth API keys and showing connected state in the section header, active connections rail, and featured CTA.

Issues found:

  • The encoding bug at line 1098 (McpConnectedPill) was fixed ✓
  • Two instances of · instead of · remain in McpRailRow at lines 1511 and 1528

Score: 8/10

The logic and structure look solid. The code correctly reuses the existing MCP metadata signals, properly handles null/undefined cases, and integrates cleanly with the existing rail entry system. The activeMcpKey memo correctly finds the most recent key by comparing timestamps.

Fix the remaining two encoding issues and this is good to ship.

Comment thread apps/web/components/integrations-view.tsx Outdated
Comment thread apps/web/components/integrations-view.tsx Outdated
ishaanxgupta and others added 2 commits June 22, 2026 17:11
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

@MaheshtheDev MaheshtheDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mcp icon instead of black icon in active status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants