fix(cli): abort install/uninstall when existing config cannot be parsed - #35
Merged
Conversation
Parse and merge into the user's Codex config instead of silently rewriting from empty on TOML/JSON errors, and apply the same fail-closed write path for supermemory.json. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Replace tag-triggered publishes with a main-branch workflow that bumps the patch version, publishes, and commits the bump back. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
install/uninstallwhen existingconfig.tomlorhooks.jsoncannot be parsed, instead of rewriting from an empty object (fixes data-loss risk in Install/uninstall can overwrite Codex config when config parsing fails #33).supermemory.jsoninstall defaults.main(patch bump + publish; no tag/release trigger).Supersedes the approach in #34 with a simpler parse-and-merge + abort-on-parse-fail fix.
Test plan
npm test(includes new regression tests)~/.codex/config.tomlsyntax → install exits non-zero and leaves the file untouchedcodex_hookswithout dropping other settingschore(release): x.y.zmainbranch workflow (not onlyv*tags)