fix(document-api): subsume inline cell changes inside a whole-table tracked change#3663
Open
andrii-harbour wants to merge 5 commits into
Open
Conversation
…racked change trackChanges.list returned the structural whole-table change PLUS the inline trackInsert/trackDelete marks on its cell content as separate review items, breaking the "one whole table = one logical change" contract. groupTrackedChanges now drops inline grouped entries fully contained in a decidable whole-table structural range before appending the structural change, mirroring the comments-store / review-UI containment rule. Only decidable whole-table ranges suppress; a partial or undecidable structural shape keeps its inline marks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00b05302d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…inline-cell-changes-alongside
…-changes-alongside' of github.com:superdoc-dev/superdoc into andrii/sd-3385-bug-trackchangeslist-returns-inline-cell-changes-alongside
…inline-cell-changes-alongside
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trackChanges.list returned the structural whole-table change PLUS the inline trackInsert/trackDelete marks on its cell content as separate review items, breaking the "one whole table = one logical change" contract. groupTrackedChanges now drops inline grouped entries fully contained in a decidable whole-table structural range before appending the structural change, mirroring the comments-store / review-UI containment rule. Only decidable whole-table ranges suppress; a partial or undecidable structural shape keeps its inline marks.