SD-2527 - feat: implement new types of ordered lists#2873
SD-2527 - feat: implement new types of ordered lists#2873chittolinag wants to merge 7 commits intomainfrom
Conversation
chittolinag
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 038936be5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| listRendering: { | ||
| keepOnSplit: false, | ||
| renderDOM: ({ listRendering }) => { | ||
| console.log('listRendering', listRendering); |
There was a problem hiding this comment.
The new console.log('listRendering', listRendering) runs inside paragraph renderDOM, so it executes for every paragraph render/update in normal editing. This will flood production consoles and adds avoidable overhead on large documents, making real diagnostics harder and slowing interactive operations.
Useful? React with 👍 / 👎.
| role="menuitem" | ||
| :aria-label="button.ariaLabel" | ||
| ref="buttonRefs" | ||
| @keydown.prevent="(event) => handleKeyDown(event, index)" |
There was a problem hiding this comment.
Using @keydown.prevent on each style button prevents default behavior for all keys, but the handler only processes arrow keys and Enter. When a user tabs onto these options, pressing Tab is suppressed, so keyboard users cannot advance focus out of the dropdown via normal tab navigation (same pattern is used in the numbered variant), creating an accessibility and usability regression.
Useful? React with 👍 / 👎.
3 participants
Introducing new types of ordered lists:
Even though we supported rendering the styles when opening documents from Word, the user couldn't start a new list using these types.
This PR introduces a dropdown that allows the user to do so.
Note
This PR depends on #2857. Let's merge the other one first.