fix: place cursor at clicked pos inside tracked change#2855
Open
artem-harbour wants to merge 1 commit intomainfrom
Open
fix: place cursor at clicked pos inside tracked change#2855artem-harbour wants to merge 1 commit intomainfrom
artem-harbour wants to merge 1 commit intomainfrom
Conversation
superdoc-bot
bot
added
review: thorough
review: careful
and removed
review: thorough
labels
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artem-harbour
force-pushed
the
artem/SD-2612
branch
from
0bf65cb to
0a7c313
Compare
artem-harbour
force-pushed
the
artem/SD-2612
branch
from
0a7c313 to
14be365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: SD-2612
Fix caret placement inside tracked-change text on click.
This updates
EditorInputManagerto treat direct clicks on tracked-change spans the same way we already treat direct single-thread comment highlights (SD-2442): do not short-circuit tosetCursorById, and let normal click-to-position place the caret at the clicked location.Also fixes repeat-click behavior so subsequent direct clicks inside the same tracked change continue to reposition the caret instead of being ignored by the active-thread repeat-click guard.
Includes unit test updates in
EditorInputManager.activeCommentClick.test.tsto cover: