Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
artem-harbour
force-pushed
the
artem/SD-2446
branch
from
e3a2d87 to
da8d19c
Compare
chittolinag
approved these changes
Apr 17, 2026
Contributor
chittolinag
left a comment
chittolinag
left a comment
There was a problem hiding this comment.
LGTM! Approved, but left a small comment on the test.
| const lineAfter = fragmentAfter.querySelector('.superdoc-line') as HTMLElement; | ||
|
|
||
| expect(fragmentAfter).toBe(fragmentBefore); | ||
| expect(fragmentAfter).not.toBe(fragmentBefore); |
Contributor
There was a problem hiding this comment.
@artem-harbour I think it makes more sense to use toEqual here. I know that the old code was already using toBe, but toBe does a strict comparison using ===. This means that the objects could be semantically the same, but toBe would still result in false.
Jest's doc:
artem-harbour
force-pushed
the
artem/SD-2446
branch
2 times, most recently
from
9c16409 to
efbeb86
Compare
artem-harbour
force-pushed
the
artem/SD-2446
branch
from
efbeb86 to
9d51ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: SD-2446