Skip to content

fix(react): use semantic-release-pnpm to resolve workspace deps on publish#2023

Merged
harbournick merged 1 commit intomainfrom
tadeu/sd-1908-superdoc-devreact-latest-has-invalid-dependency-spec
Feb 13, 2026
Merged

fix(react): use semantic-release-pnpm to resolve workspace deps on publish#2023
harbournick merged 1 commit intomainfrom
tadeu/sd-1908-superdoc-devreact-latest-has-invalid-dependency-spec

Conversation

@tupizz
Copy link
Contributor

@tupizz tupizz commented Feb 13, 2026

Summary

  • Switches @superdoc-dev/react release config from @semantic-release/npm to semantic-release-pnpm (already used by the superdoc package)
  • @semantic-release/npm runs npm publish which does not resolve pnpm workspace:* references — this caused v1.0.0-canary.2 to ship with "superdoc": "workspace:*", breaking npm install for consumers
  • semantic-release-pnpm runs pnpm publish which properly resolves workspace protocols to actual version numbers

Closes SD-1908

Test plan

  • Verify semantic-release-pnpm is already a root dependency (it is — used by superdoc)
  • Verify the next react release publishes with resolved dependency versions
  • Manually update @latest dist-tag to point to a working version

Copilot AI review requested due to automatic review settings February 13, 2026 15:47
@linear
Copy link

linear bot commented Feb 13, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical publishing issue in the @superdoc-dev/react package by switching from @semantic-release/npm to semantic-release-pnpm for the release process. The previous plugin (@semantic-release/npm) uses npm publish, which does not resolve pnpm workspace protocols, causing version 1.0.0-canary.2 to be published with the literal string "superdoc": "workspace:*" instead of a concrete version number. This broke installations for consumers. The semantic-release-pnpm plugin properly resolves workspace protocols during publish.

Changes:

  • Replace @semantic-release/npm with semantic-release-pnpm in the react package release configuration
  • Align react package release configuration with the superdoc package (which already uses semantic-release-pnpm)
  • Prevent future releases from shipping with unresolved workspace protocols

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tupizz tupizz enabled auto-merge (squash) February 13, 2026 15:52
@tupizz tupizz force-pushed the tadeu/sd-1908-superdoc-devreact-latest-has-invalid-dependency-spec branch from d3792b3 to 5f110eb Compare February 13, 2026 16:03
…blish (SD-1908)

The react package was using @semantic-release/npm which runs `npm publish`
and does not resolve pnpm workspace:* references. This caused version
1.0.0-canary.2 to be published with "superdoc": "workspace:*" as a
dependency, breaking npm installs for consumers.

Switch to semantic-release-pnpm (already used by the superdoc package)
which runs `pnpm publish` and properly resolves workspace:* to actual
version numbers before publishing.
@tupizz tupizz force-pushed the tadeu/sd-1908-superdoc-devreact-latest-has-invalid-dependency-spec branch from 419e7d4 to a4c8ff0 Compare February 13, 2026 16:29
@tupizz tupizz self-assigned this Feb 13, 2026
Copy link
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harbournick harbournick disabled auto-merge February 13, 2026 18:33
@harbournick harbournick merged commit d93205a into main Feb 13, 2026
3 checks passed
@harbournick harbournick deleted the tadeu/sd-1908-superdoc-devreact-latest-has-invalid-dependency-spec branch February 13, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants