fix: keep smtp_pass consistent in auth config. #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savme
reviewed
Nov 29, 2025
Collaborator
savme
left a comment
savme
left a comment
There was a problem hiding this comment.
Thanks for jumping in and fixing this, @JEETDESAI25! 🙏
Let's just make a small tweak in the error handling and we’ll be good to merge
JEETDESAI25
force-pushed
the
fix/issue-202-smtp-pass
branch
2 times, most recently
from
8754171 to
6eb3ff0
Compare
savme
approved these changes
Dec 2, 2025
savme
force-pushed
the
fix/issue-202-smtp-pass
branch
from
6eb3ff0 to
d253a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Closes #202
When using smtp_pass in auth config, Terraform fails with "Provider produced inconsistent result after apply" because readAuthConfig() marshals the API response (AuthConfigResponse) with different JSON tags than the update schema (UpdateAuthConfigBody), causing state mismatch.
What is the new behavior?
Additional context
All tests pass (7/7). Verified with golangci-lint (0 issues).