Skip to content

Conversation

@SoulSniper1212
Copy link

Overview

This PR fixes issue #1306 by ensuring that a default storage provider is used when none is explicitly provided in the client options. Previously, the auth client would receive None as the storage provider, which could cause issues. Now, the async client uses AsyncMemoryStorage() and the sync client uses SyncMemoryStorage() as fallbacks.

Checklist

  • Code changes have been made to handle missing storage in client options
  • Default storage providers are set appropriately for async and sync clients
  • Changes maintain backward compatibility
  • Tests have been added/updated to verify the fix
  • Documentation has been updated (if applicable)

Proof

The fix ensures that when client_options.storage is None (which happens when using base ClientOptions), the appropriate default memory storage is provided to the auth client. This prevents any potential issues from a missing storage provider while maintaining the existing behavior when a storage provider is explicitly configured.

Closes

Closes #1306

Signed-off-by: SoulSniper1212 <warush23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientOptions causes AttributeError: 'storage' attribute missing in v2.24.0

1 participant