fix(auth): provide default storage when none provided in client options #1307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes issue #1306 by ensuring that a default storage provider is used when none is explicitly provided in the client options. Previously, the auth client would receive
Noneas the storage provider, which could cause issues. Now, the async client usesAsyncMemoryStorage()and the sync client usesSyncMemoryStorage()as fallbacks.Checklist
Proof
The fix ensures that when
client_options.storageisNone(which happens when using baseClientOptions), the appropriate default memory storage is provided to the auth client. This prevents any potential issues from a missing storage provider while maintaining the existing behavior when a storage provider is explicitly configured.Closes
Closes #1306