[validation only] Go pin removal on top of AMI volume bump - #2340
Closed
brainrake wants to merge 2 commits into
Closed
[validation only] Go pin removal on top of AMI volume bump#2340brainrake wants to merge 2 commits into
brainrake wants to merge 2 commits into
Conversation
PostgreSQL Extension Dependency Analysis: PR #2340
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2340
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
brainrake
force-pushed
the
fix/supascan-go-version-on-diskfix
branch
from
August 1, 2026 16:13
0fb82f5 to
11788c8
Compare
|
Found 108 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
go_1_24 is missing in the upcoming nixpkgs 26.05pre bump used by #2328's flake.lock update; go_1_25 is the newest Go version present in both the current and the bumped nixpkgs, so pinning to it keeps these packages building across the update.
pkgs.go already resolves to 1.25.x on both the current and the bumped nixpkgs (25.11pre -> 26.05pre), well above the >= 1.23.2 requirement, so the explicit go_1_24/go_1_25 override was redundant and fragile across nixpkgs bumps. Using plain pkgs.buildGoModule matches how the other Go packages in this flake (goss, pg-startup-profiler, packer, wal-g) are already built.
brainrake
force-pushed
the
fix/supascan-go-version-on-diskfix
branch
from
August 1, 2026 23:34
11788c8 to
317b8f3
Compare
Collaborator
Author
|
Validation result: blocked, not about the Go fix itself. This PR exists to test #2329's Go pin removal against `test-ami-nix (15, ...)`, gated on fixing the unrelated `No space left on device` AMI build failure (see #2339). Both disk-space fix attempts in #2339 failed to actually resolve it:
Root cause of the disk-space issue is still unidentified. This PR can't produce a real signal on the Go fix until that's sorted - closing as validation-only rather than leaving it open on a broken premise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary validation PR: #2329's Go pin removal rebased onto #2339's 20GB build volume bump, to confirm test-ami-nix (15, amd64/arm64) passes with the larger volume. Will close once confirmed.