fix: lower default max_slot_wal_keep_size from 4096MB to 512MB#2130
Draft
Crispy1975 wants to merge 1 commit intodevelopfrom
Draft
fix: lower default max_slot_wal_keep_size from 4096MB to 512MB#2130Crispy1975 wants to merge 1 commit intodevelopfrom
Crispy1975 wants to merge 1 commit intodevelopfrom
Conversation
The 4096MB default exceeds the total disk size of free tier projects (2GB), risking disk exhaustion from a lagging or disconnected slot. 512MB fits safely within free tier disk overhead while still providing a reasonable buffer for logical replication slots (e.g. Realtime, CDC). WAL archiving to S3 means local retention is not needed for recovery.
8623ef2 to
8811421
Compare
samrose
approved these changes
May 1, 2026
hitmands
reviewed
May 1, 2026
hitmands
left a comment
There was a problem hiding this comment.
this change isn't scoped to the free tier only, and as per my comment here https://github.com/supabase/supabase-admin-api/pull/316#pullrequestreview-4210781796, I think this affects how the replication streaming works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_slot_wal_keep_sizewas set to4096MB, exceeding the total disk size of free tier projects (2GB) — a lagging or disconnected replication slot could fill the disk entirely before Postgres invalidates it512MB, which fits safely within free tier disk overheadarchive_commandmeans local WAL retention is not required for recovery, so a lower cap has no impact on PITRTest plan