Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/actions/nix-install-ephemeral/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,14 @@ runs:
trusted-public-keys = nix-postgres-artifacts:dGZlQOvKcNEjvT7QEAJbcV6b6uk7VF/hWMjhYleiaLI= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
${{ inputs.push-to-cache == 'true' && 'post-build-hook = /etc/nix/upload-to-cache.sh' || '' }}
max-jobs = 4
extra-system-features = kvm
- name: Setup KVM permissions
shell: bash
run: |
if [ -e /dev/kvm ]; then
sudo chown runner /dev/kvm
sudo chmod 666 /dev/kvm
echo "KVM configured: $(ls -l /dev/kvm)"
else
echo "KVM device not available"
fi
8 changes: 6 additions & 2 deletions nix/ext/tests/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ let
nodes.server =
{ config, ... }:
{
# VM resources — sized for nested virtualisation on ephemeral CI runners
virtualisation.memorySize = 4096;
virtualisation.cores = 2;

services.openssh = {
enable = true;
};
Expand Down Expand Up @@ -278,7 +282,7 @@ let

has_update_script = False
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
"${pg17-configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -320,7 +324,7 @@ let
test.check_pg_regress(Path("${psql_17}/lib/pgxs/src/test/regress/pg_regress"), "17", pg_regress_test_name)

with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
"${orioledb17-configuration}/bin/switch-to-configuration test >&2"
)
installed_extensions=test.run_sql("""SELECT extname FROM pg_extension WHERE extname = 'orioledb';""")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/http.nix
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -167,7 +167,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/index_advisor.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -134,7 +134,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 4 additions & 0 deletions nix/ext/tests/lib.nix
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ let
in
{ ... }:
{
# VM resources — sized for nested virtualisation on ephemeral CI runners
virtualisation.memorySize = 4096;
virtualisation.cores = 2;

# System users
users.users.postgres = {
isSystemUser = true;
Expand Down
2 changes: 1 addition & 1 deletion nix/ext/tests/orioledb-rewind.nix
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pkgs.testers.runNixOSTest {
server.wait_for_unit("supabase-db-init.service")
with subtest("Switch to OrioleDB and show rewind config"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
2 changes: 1 addition & 1 deletion nix/ext/tests/orioledb.nix
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pkgs.testers.runNixOSTest {
server.wait_for_unit("supabase-db-init.service")

with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pg_plan_filter.nix
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ pkgs.testers.runNixOSTest {
check_plan_filter(server)
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand All @@ -88,7 +88,7 @@ pkgs.testers.runNixOSTest {
check_plan_filter(server)
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pg_repack.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -138,7 +138,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pgjwt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -134,7 +134,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pgmq.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -134,7 +134,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pgroonga.nix
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -140,7 +140,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pgrouting.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -138,7 +138,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/pgsodium.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand All @@ -131,7 +131,7 @@ pkgs.testers.runNixOSTest {
test.assert_version_matches(last_version)
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/plpgsql_check.nix
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand All @@ -132,7 +132,7 @@ pkgs.testers.runNixOSTest {
test.assert_version_matches(last_version)
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/postgis.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -134,7 +134,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
4 changes: 2 additions & 2 deletions nix/ext/tests/vault.nix
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ pkgs.testers.runNixOSTest {
last_version = test.check_install_last_version("15")
with subtest("switch to postgresql 17"):
server.succeed(
server.execute(
f"{pg17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("postgresql.service")
Expand Down Expand Up @@ -134,7 +134,7 @@ pkgs.testers.runNixOSTest {
test.check_upgrade_path("17")
with subtest("switch to orioledb 17"):
server.succeed(
server.execute(
f"{orioledb17_configuration}/bin/switch-to-configuration test >&2"
)
server.wait_for_unit("supabase-db-init.service")
Expand Down
21 changes: 10 additions & 11 deletions nix/packages/github-matrix/github_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class NixEvalError(TypedDict):
BUILD_RUNNER_MAP: Dict[RunnerType, Dict[System, RunsOnConfig]] = {
"ephemeral": {
"aarch64-linux": {
"labels": ["blacksmith-8vcpu-ubuntu-2404-arm"],
"labels": ["blacksmith-16vcpu-ubuntu-2404-arm"],
},
"x86_64-linux": {
"labels": ["blacksmith-8vcpu-ubuntu-2404"],
Expand All @@ -81,10 +81,6 @@ class NixEvalError(TypedDict):
"group": "self-hosted-runners-nix",
"labels": ["aarch64-darwin"],
},
"aarch64-linux": {
"group": "self-hosted-runners-nix",
"labels": ["aarch64-linux"],
},
},
}

Expand Down Expand Up @@ -255,18 +251,21 @@ def get_runner_for_package(pkg: NixEvalJobsOutput) -> RunsOnConfig | None:
"""Determine the appropriate GitHub Actions runner for a package.

Priority order:
1. KVM packages → self-hosted runners
2. Large packages on Linux → 32vcpu ephemeral runners
3. Darwin packages → self-hosted runners
4. Default → ephemeral runners
1. KVM packages on Darwin → self-hosted runners
2. KVM packages on Linux → ephemeral runners
3. Large packages on Linux → 32vcpu ephemeral runners
4. Darwin packages → self-hosted runners
5. Default → ephemeral runners
"""
system = pkg["system"]

if is_kvm_pkg(pkg):
runConfig = BUILD_RUNNER_MAP["self-hosted"].get(system)
if system == "aarch64-darwin":
return BUILD_RUNNER_MAP["self-hosted"]["aarch64-darwin"]
runConfig = BUILD_RUNNER_MAP["ephemeral"].get(system)
if runConfig is None:
raise ValueError(
f"No self-hosted with kvm support available for system: {system}"
f"No ephemeral runner with kvm support available for system: {system}"
)
return runConfig

Expand Down
14 changes: 6 additions & 8 deletions nix/packages/github-matrix/tests/test_github_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,10 @@ def test_kvm_package_x86_64_linux(self):
"system": "x86_64-linux",
"requiredSystemFeatures": ["kvm"],
}
with pytest.raises(
ValueError,
match=r"No self-hosted with kvm support available for system: x86_64-linux",
):
get_runner_for_package(pkg)
result = get_runner_for_package(pkg)
assert result == {
"labels": ["blacksmith-8vcpu-ubuntu-2404"],
}

def test_kvm_package_aarch64_linux(self):
pkg: NixEvalJobsOutput = {
Expand All @@ -121,8 +120,7 @@ def test_kvm_package_aarch64_linux(self):
}
result = get_runner_for_package(pkg)
assert result == {
"group": "self-hosted-runners-nix",
"labels": ["aarch64-linux"],
"labels": ["blacksmith-16vcpu-ubuntu-2404-arm"],
}

def test_large_package_x86_64_linux(self):
Expand Down Expand Up @@ -212,7 +210,7 @@ def test_default_aarch64_linux(self):
"system": "aarch64-linux",
}
result = get_runner_for_package(pkg)
assert result == {"labels": ["blacksmith-8vcpu-ubuntu-2404-arm"]}
assert result == {"labels": ["blacksmith-16vcpu-ubuntu-2404-arm"]}


class TestSortPkgsByClosures:
Expand Down
Loading