Repository navigation
ci: shorten the Test workflow e2e critical path - #7159
Conversation
…edundant Go build Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/ai-review |
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews were available: Claude reported three findings and Codex reported none. Code inspection confirms one minor performance advisory and two nits concerning test coverage and documentation. Actual cli-e2e shard imbalance is unmeasured. No major or critical defect was substantiated.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | .github/workflows/test.yml:415 |
ci-performance |
claude | The new cli-e2e shards inherit Vitest's default sharding rather than the timing-aware packing used by apps/cli. Because cli-e2e files run serially, unequal file durations can limit the wall-time benefit. |
| ⚪ NIT | apps/cli/tests/e2e-sequencer.ts:153 |
test-coverage |
claude | The new E2eSequencer.shard wiring for project classification and configured worker count has no direct test coverage. |
| ⚪ NIT | apps/cli/tests/e2e-sequencer.ts:63 |
documentation |
claude | The determinism comment incorrectly says the partition depends only on the file set; worker count also affects assignment, so shard processes need matching packing inputs. |
Stats
Claude findings: 3 · Codex findings: 0 · Confirmed: 3 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
There was a problem hiding this comment.
🤖 AI Review
Verified both reviews. Confirmed one non-blocking CI performance nit and refuted the missing-Go-binary regression: the existing Turbo build builds or restores the referenced binary. No confirmed correctness bugs.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | .github/workflows/test.yml:415 |
ci-performance |
claude | The new cli-e2e shards use Vitest's default path-hash partition rather than measured durations, so uneven runtimes may limit the speedup. |
Refuted findings (kept for transparency, not posted as review comments)
.github/workflows/test.yml:417(test-infrastructure): Removing the explicit Go binary cache and build steps leaves SUPABASE_GO_BINARY pointing at a missing binary, causing delegated-command tests to fail on fresh runners.
Refuted: .github/workflows/test.yml:403-404 still runs turbo run supabase#build before testing. turbo.json:64-66 explicitly makes that task depend on @supabase/cli-go#build. apps/cli-go/package.json:5 builds the exact referenced file with go build -o supabase-go ., and turbo.json:58-62 declares supabase-go as a cached output, so cache hits restore it. apps/cli/package.json:28 then copies this binary into dist. The removed workflow steps were redundant.
Stats
Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
…ndows test jobs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the macOS store archive Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit e58f277.
This reverts commit acee9d7.
This reverts commit 31b3ece.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit c69ff75.
…fewer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… runner fewer" This reverts commit 906f771.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 67cf450.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This reverts commit 6b12298.
This reverts commit 8385f05.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…load Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to #7129. CLI e2e jobs now set the Test workflow's wall time.
@supabase/cli-e2esuite into two shards; it was the single longest job.e2eproject's workers, because they contend for one Docker daemon, and exclusive files add their full duration.actions/cache+go buildsteps in e2e jobs;supabase#buildalready builds or restores@supabase/cli-gothrough turbo.gen typese2e readiness probe connects over TCP. The Postgres entrypoint's init server listens only on the Unix socket, so a socket probe could pass before the final server started and the seed then failed mid-restart.Measured over repeated CI runs against develop after #7129:
Required check names are unchanged.
🤖 Generated with Claude Code