Repository navigation
chore(repo): sync develop into next - #7141
Conversation
This bumps storage from v1.81.3-r0 to v1.81.4-r0. https://github.com/supabase/slim-services/releases/tag/storage-v1.81.4-r0 Planned after supabase/slim-services published v1.81.4-r0. This branch is rewritten from develop whenever a newer relevant release arrives. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This bumps realtime from v2.143.3-r0 to v2.143.4-r0. https://github.com/supabase/slim-services/releases/tag/realtime-v2.143.4-r0 Planned after supabase/slim-services published v2.143.4-r0. This branch is rewritten from develop whenever a newer relevant release arrives. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This bumps storage from v1.81.4-r0 to v1.81.5-r0. https://github.com/supabase/slim-services/releases/tag/storage-v1.81.5-r0 Planned after supabase/slim-services published v1.81.5-r0. This branch is rewritten from develop whenever a newer relevant release arrives. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…2693) (#7122) ## TL;DR moves the remaining commands that predate the effect skill onto it, with no change in behaviour ## whats introduced? <details> <summary>commands covered</summary> `start` `stop` `status` `services` `init` `link` `unlink` `bootstrap` `db` `migration` `inspect` `seed` `test` & `stack` </details> - error recovery narrows to `catchTag`, `catchTags` and `catchReason` instead of broad catches and `_tag` checks - casts and non null assertions give way to `Predicate` narrowing, exhaustive `Match` and schema decoding - mutable state read by finalizers moves into `Ref`, and the shadow port retry goes through `Schedule` - the pg-delta services use `Effect.fn` under their existing span names, adding `PgAdmin.diff` and two `stack start` spans - tests run on `it.effect` and wait on `Deferred` instead of polling, staying on `it.live` only where a real clock, process, server or backoff is involved ## notes - no user facing behaviour change.. - output, exit codes, errors and telemetry match develop, and the new spans only appear in trace output and the `SUPABASE_DEBUG=1` span console - the shadow port probe now also closes its server when interrupted instead of leaking it ## ref - closes: CLI-2693 - extends: #7092
This PR was automatically created to sync the generated `@supabase/api` package with the latest Management API OpenAPI document. Changes were detected in the upstream OpenAPI documents exposed by `https://api.supabase.com/api/v1-json` and `https://api.supabase.com/api/v2-json`. Co-authored-by: jgoux <1443499+jgoux@users.noreply.github.com>
# Conflicts: # apps/cli-go/pkg/config/templates/Dockerfile # apps/cli/src/commands/bootstrap/bootstrap.handler.ts # apps/cli/src/commands/bootstrap/bootstrap.templates.integration.test.ts # apps/cli/src/commands/db/advisors/advisors.format.ts # apps/cli/src/commands/db/advisors/advisors.integration.test.ts # apps/cli/src/commands/db/diff/diff.integration.test.ts # apps/cli/src/commands/db/dump/dump.handler.ts # apps/cli/src/commands/db/dump/dump.integration.test.ts # apps/cli/src/commands/db/lint/lint.format.ts # apps/cli/src/commands/db/lint/lint.integration.test.ts # apps/cli/src/commands/db/pull/pull.integration.test.ts # apps/cli/src/commands/db/push/push.integration.test.ts # apps/cli/src/commands/db/query/query.format.ts # apps/cli/src/commands/db/query/query.integration.test.ts # apps/cli/src/commands/db/reset/reset.integration.test.ts # apps/cli/src/commands/db/schema/declarative/generate/generate.integration.test.ts # apps/cli/src/commands/db/schema/declarative/sync/sync.integration.test.ts # apps/cli/src/commands/db/shared/pgdelta.seam.integration.test.ts # apps/cli/src/commands/db/start/start.integration.test.ts # apps/cli/src/commands/db/test/test.integration.test.ts # apps/cli/src/commands/experimental/stack/stack-forwarding.integration.test.ts # apps/cli/src/commands/init/init.integration.test.ts # apps/cli/src/commands/inspect/report/report.config.ts # apps/cli/src/commands/link/link.integration.test.ts # apps/cli/src/commands/migration/down/down.integration.test.ts # apps/cli/src/commands/migration/fetch/fetch.integration.test.ts # apps/cli/src/commands/migration/list/list.integration.test.ts # apps/cli/src/commands/migration/migration.integration.test.ts # apps/cli/src/commands/migration/new/new.integration.test.ts # apps/cli/src/commands/migration/repair/repair.integration.test.ts # apps/cli/src/commands/migration/squash/squash.diff.unit.test.ts # apps/cli/src/commands/migration/squash/squash.integration.test.ts # apps/cli/src/commands/seed/buckets/buckets.flags.unit.test.ts # apps/cli/src/commands/seed/buckets/buckets.integration.test.ts # apps/cli/src/commands/services/services.integration.test.ts # apps/cli/src/commands/start/start.gates.ts # apps/cli/src/commands/start/start.handler.ts # apps/cli/src/commands/start/start.integration.test.ts # apps/cli/src/commands/start/start.string-slice-flags.integration.test.ts # apps/cli/src/commands/status/status.command.unit.test.ts # apps/cli/src/commands/status/status.integration.test.ts # apps/cli/src/commands/status/status.string-slice-flags.integration.test.ts # apps/cli/src/commands/stop/stop.integration.test.ts # apps/cli/src/commands/test/new/new.integration.test.ts
Claude resolved the merge of
|
| File | Resolution |
|---|---|
apps/cli/src/commands/start/start.handler.ts |
Uses next's resolver calls: no project env values, context.document, parseDuration, and resolveStartGates({ config, excludedKeys }). These are wrapped in develop's tryStartConfig helper, and develop's timebox check without the non-null assertion is kept. |
apps/cli/src/commands/start/start.gates.ts |
Took next's version, which drops the document input and asRecord. The Predicate import is removed because nothing uses it any more. |
apps/cli/src/commands/bootstrap/bootstrap.handler.ts |
Keeps next's writeThrough wrapper, the writeDotEnv span and seed resolution. Inside them it uses develop's Effect.as way of tracking whether .env was written and develop's yield* bootstrapRetryNotify; the unused Redacted import is removed. |
apps/cli/src/commands/db/lint/lint.format.ts |
Uses develop's Predicate.isObject checks with next's HTML-safe JSON encoder and next's 'invalid …: expected an object' error messages. |
apps/cli/src/commands/db/advisors/advisors.format.ts |
Uses develop's Predicate.isObject checks with next's HTML-safe JSON encoder and next's error messages. |
apps/cli/src/commands/db/query/query.format.ts |
Uses develop's Predicate.isObject narrowing with next's formatJsonValue name. |
apps/cli/src/commands/inspect/report/report.config.ts |
Took next's rewrite, which reads rules through CliConfigValues. Develop's changes only cleaned up code that next removed. |
apps/cli/src/commands/db/dump/dump.handler.ts |
Uses next's supabase-env import, and drops the DockerRunError import as develop did. |
apps/cli/src/commands/start/start.integration.test.ts |
Next's titles and moved tests in it.effect style; develop's duplicate copies of the moved tests are removed. Develop's Deferred-based SIGINT probe is kept because next's sleep loop would not work under the virtual clock. |
apps/cli/src/commands/status/status.integration.test.ts |
Next's titles, the goOutput→outputFlag rename and next's two new tests, all in develop's it.effect style. |
apps/cli/src/commands/services/services.integration.test.ts |
Next's outputFlag rename, titles and new parameterised invalid-config test, in it.effect style. |
apps/cli/src/commands/init/init.integration.test.ts |
Develop's assertion style with next's titles and error messages. |
apps/cli/src/commands/seed/buckets/buckets.integration.test.ts |
Next's titles, error text and new tests in it.effect style. Next's single both-backends port-validation test replaces develop's two. |
apps/cli/src/commands/db/query/query.integration.test.ts |
Next's titles and outputFlag rename, with develop's it.effect. |
apps/cli/src/commands/db/reset/reset.integration.test.ts |
Next's titles, config tweaks and new seed and remote tests, all converted to it.effect to match develop. |
apps/cli/src/commands/db/push/push.integration.test.ts |
Next's titles, including its reversed shell-env vs remote-block precedence, and next's new tests in it.effect style. Develop's toBeInstanceOf(DbPushApplyError) check is kept. |
apps/cli/src/commands/db/dump/dump.integration.test.ts |
Next's titles and its two new --password rejection tests, in it.effect style. |
apps/cli/src/commands/db/start/start.integration.test.ts |
Next's titles and its CliConfigValueError assertions, in it.effect style. |
apps/cli/src/commands/db/advisors/advisors.integration.test.ts |
Next's titles with develop's Effect.flip assertions. |
apps/cli/src/commands/db/diff/diff.integration.test.ts |
Next's useMigra flag and engine-conflict message, with develop's cast-free optional chaining. |
apps/cli/src/commands/db/pull/pull.integration.test.ts |
Next's diffEngine flag with develop's Effect.flip assertions. |
apps/cli/src/commands/db/test/test.integration.test.ts |
Next's title in it.effect. Keeps develop's TestDbFlags type import and drops the unused GoProxy import. |
apps/cli/src/commands/migration/list/list.integration.test.ts |
Develop's flip style asserting next's DbPasswordFlagsError, plus next's new --local/--password test. |
apps/cli/src/commands/migration/squash/squash.integration.test.ts |
Develop's flip style with next's DbPasswordFlagsError and next's new message. |
apps/cli/src/commands/migration/repair/repair.integration.test.ts |
Next's titles and its new --password/--local test, rewritten in develop's flip style. |
apps/cli/src/commands/db/schema/declarative/generate/generate.integration.test.ts |
Next's disablePgDelta gating and new password-flag test, rewritten with Effect.flip because develop removed the failError helper it used. |
apps/cli/src/commands/db/schema/declarative/sync/sync.integration.test.ts |
Next's takeApplyFailure and disablePgDelta logic, with develop's typed DbExecError instead of the cast. |
apps/cli/src/commands/db/shared/pgdelta.seam.integration.test.ts |
Import line: next's FileSystem and Path are added for its new test, and Cause is dropped as develop did. |
apps/cli/src/commands/stop/stop.integration.test.ts |
Next's titles and new invalid-config test, in it.effect style. |
apps/cli/src/commands/seed/buckets/buckets.flags.unit.test.ts |
Develop's it.effect/Effect.flip test with next's title, which drops the word 'cobra'. |
apps/cli/src/commands/status/status.command.unit.test.ts |
Develop's it.effect with next's titles, which drop the pflag references. |
apps/cli/src/commands/experimental/stack/stack-forwarding.integration.test.ts |
Develop's it.effect, plus next's two new secret-decryption tests converted to it.effect. |
apps/cli/src/commands/link/link.integration.test.ts |
Next's title and its added cliConfigValuesTestLayer, with develop's it.effect. |
apps/cli/src/commands/migration/fetch/fetch.integration.test.ts |
Next's titles with develop's it.effect. |
apps/cli/src/commands/migration/new/new.integration.test.ts |
Next's title with develop's it.effect and flip assertions. |
apps/cli/src/commands/migration/migration.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/migration/down/down.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/migration/squash/squash.diff.unit.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/bootstrap/bootstrap.templates.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/test/new/new.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/db/lint/lint.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/start/start.string-slice-flags.integration.test.ts |
Next's title with develop's it.effect. |
apps/cli/src/commands/status/status.string-slice-flags.integration.test.ts |
Next's title with develop's it.effect. |
Deleted: apps/cli-go/pkg/config/templates/Dockerfile.
Decisions for @supabase/cli. Confirm them, or push a change to this branch:
- Develop updated
apps/cli-go/pkg/config/templates/Dockerfile, which next deleted along with the rest of cli-go. Chose: Delete it. Next'sapps/cli/src/shared/services/Dockerfilehas identical content, so develop's image bumps are already there. - Develop refactored the env-override plumbing (projectEnvValues, the document passed to start gates) that next removed. Chose: Follow next and drop the env-override parameters. Develop's error-wrapping and type-safety cleanups are applied to next's resolver calls.
- Next moved several start tests and replaced two of develop's seed-buckets backend tests with one. Chose: Keep next's moved and replacement tests, converted to develop's it.effect style, and drop develop's duplicates.
Quick checks. The merged tree passes check:all and unit tests.
Approve to fast-forward next once checks pass (workflow run).
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported zero findings, leaving nothing to adjudicate. The supplied pr.diff is empty, so this pass could not independently assess the PR changes. Tests were not run.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Merging
developintonextconflicts. This branch starts at the tip ofdevelop(c690376);nextis at2441fbf.Conflicting files:
apps/cli-go/pkg/config/templates/Dockerfileapps/cli/src/commands/bootstrap/bootstrap.handler.tsapps/cli/src/commands/bootstrap/bootstrap.templates.integration.test.tsapps/cli/src/commands/db/advisors/advisors.format.tsapps/cli/src/commands/db/advisors/advisors.integration.test.tsapps/cli/src/commands/db/diff/diff.integration.test.tsapps/cli/src/commands/db/dump/dump.handler.tsapps/cli/src/commands/db/dump/dump.integration.test.tsapps/cli/src/commands/db/lint/lint.format.tsapps/cli/src/commands/db/lint/lint.integration.test.tsapps/cli/src/commands/db/pull/pull.integration.test.tsapps/cli/src/commands/db/push/push.integration.test.tsapps/cli/src/commands/db/query/query.format.tsapps/cli/src/commands/db/query/query.integration.test.tsapps/cli/src/commands/db/reset/reset.integration.test.tsapps/cli/src/commands/db/schema/declarative/generate/generate.integration.test.tsapps/cli/src/commands/db/schema/declarative/sync/sync.integration.test.tsapps/cli/src/commands/db/shared/pgdelta.seam.integration.test.tsapps/cli/src/commands/db/start/start.integration.test.tsapps/cli/src/commands/db/test/test.integration.test.tsapps/cli/src/commands/experimental/stack/stack-forwarding.integration.test.tsapps/cli/src/commands/init/init.integration.test.tsapps/cli/src/commands/inspect/report/report.config.tsapps/cli/src/commands/link/link.integration.test.tsapps/cli/src/commands/migration/down/down.integration.test.tsapps/cli/src/commands/migration/fetch/fetch.integration.test.tsapps/cli/src/commands/migration/list/list.integration.test.tsapps/cli/src/commands/migration/migration.integration.test.tsapps/cli/src/commands/migration/new/new.integration.test.tsapps/cli/src/commands/migration/repair/repair.integration.test.tsapps/cli/src/commands/migration/squash/squash.diff.unit.test.tsapps/cli/src/commands/migration/squash/squash.integration.test.tsapps/cli/src/commands/seed/buckets/buckets.flags.unit.test.tsapps/cli/src/commands/seed/buckets/buckets.integration.test.tsapps/cli/src/commands/services/services.integration.test.tsapps/cli/src/commands/start/start.gates.tsapps/cli/src/commands/start/start.handler.tsapps/cli/src/commands/start/start.integration.test.tsapps/cli/src/commands/start/start.string-slice-flags.integration.test.tsapps/cli/src/commands/status/status.command.unit.test.tsapps/cli/src/commands/status/status.integration.test.tsapps/cli/src/commands/status/status.string-slice-flags.integration.test.tsapps/cli/src/commands/stop/stop.integration.test.tsapps/cli/src/commands/test/new/new.integration.test.tsTo resolve:
git fetch origin git switch sync/develop-into-next git merge origin/next # resolve the conflicts, then commit git push origin sync/develop-into-nextApprove to fast-forward
next; do not use the merge button.