Repository navigation
feat(cli): warn at runtime on deprecated db pull and domains flags (CLI-2599) - #7115
Merged
Coly010 merged 2 commits intoOct 13, 2026
Conversation
…LI-2599) `domains create|get|reverify|activate|delete` now print a stderr warning when `--include-raw-output` is passed, naming `-o json` as the replacement and v3 as the removing major. The two existing `db pull` deprecation lines (`--use-pg-delta` and `--experimental` structured dump) now name v3 as well.
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews reported zero findings. Reading the PR code, tests, trusted conventions, and next-branch context revealed no actionable issues: the domains warning stays on stderr, existing output behavior is preserved, and deprecation wording consistently names v3. Tests were inspected but not run because dependencies are absent.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
3 tasks done
jgoux
approved these changes
Oct 13, 2026
Coly010
deleted the
columferry/cli-2599-warn-at-runtime-when-domains-include-raw-output-is-used
branch
October 13, 2026 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stable now warns on stderr for every flag that CLI-2596 removes in v3. Each warning names the replacement and says the flag goes away in v3.
domains create|get|reverify|activate|delete --include-raw-outputFlag --include-raw-output is deprecated and will be removed in v3, use -o json instead.(new, previously help text only)db pull --use-pg-deltaFlag --use-pg-delta is deprecated and will be removed in v3, use --declarative with [experimental.pgdelta] enabled = true in your config.toml instead.(reworded)db pull --experimental(structured dump)The --experimental structured-dump mode for `db pull` is deprecated and will be removed in v3. Use --declarative instead to pull the remote schema as per-object files.(reworded)-o json/ stream-json stdout is unchanged.--include-raw-outputstill forces JSON output, and it is still inert ondelete.--include-raw-output2 runs from 1 person,--use-pg-delta47/30,--experimental17/9. The numbers are on CLI-2596.The removal itself is in a separate PR against
next.Linked issue
Closes CLI-2599
Checklist
pnpm check:allpasses. The apps/cli unit and integration suites pass.🤖 Generated with Claude Code