-
Notifications
You must be signed in to change notification settings - Fork 451
chore(monorepo): consolidate repos CLI-1408 #5168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
687b1b9
ebb0cd2
f4d633f
88efe85
d84a2ae
e143300
2801680
0067c4e
39f6a8a
44b6eff
6001576
1b9b0d1
ea179dd
854d672
cc2c547
7708dda
98ad0d5
cbbeb62
3c7fe8d
9a35980
5becc32
72bee4a
2c95a6c
73768e1
0c09347
748b925
114a955
a0a51b8
2eeeaa2
0321793
b182e7e
b21b8da
3f6aea1
f7e735d
816b71e
20cb38b
b928dbc
bab2654
27f027b
7854c5a
0687765
75ce998
40ec804
f1744a2
5906132
c605c2c
ae17407
56f55db
2dd4f84
359e6cb
d5294d0
160c385
588ed22
885a07b
332e9f5
1bbbe43
3cea15b
66bbe5b
2cfca03
3769914
4e4f922
fd7f979
d740e5b
42eff42
c52e53d
c59942f
e65b00e
e639a92
8214fc5
7057603
e363795
cd5f8d1
48deab2
e788efe
c54dcb7
5e18fdf
240c339
8b7207f
5d1f730
07e0cef
c3f0aac
32385fd
05b0b67
c94dc8a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| * @supabase/cli | ||
| * @supabase/cli |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Setup | ||
|
|
||
| description: Perform standard setup and install dependencies using pnpm | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Install Bun | ||
| uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2 | ||
| with: | ||
| bun-version: latest | ||
|
|
||
| - name: Install Node.js | ||
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| package-manager-cache: false | ||
|
|
||
| - name: Enable Corepack | ||
| shell: bash | ||
| run: npm install --global corepack && corepack enable | ||
|
|
||
| - name: Configure dependency cache | ||
| uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6 | ||
| with: | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| shell: bash | ||
| run: pnpm install --frozen-lockfile | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,9 @@ on: | |
| repository_dispatch: | ||
| types: | ||
| - api-sync | ||
| workflow_dispatch: # allow manual triggering | ||
|
|
||
| # Add explicit permissions | ||
|
Comment on lines
-7
to
-9
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question Woudn't that turn it into something that run at any change to the go-cli source code is that what we want ? It's meant to be a manual triggering as it get "manually triggered" by an automated action each time the |
||
| workflow_dispatch: | ||
| paths: | ||
| - apps/cli-go/** | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
@@ -20,7 +20,7 @@ jobs: | |
|
|
||
| - uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
| go-version-file: apps/cli-go/go.mod | ||
| cache: true | ||
|
|
||
| - name: Run codegen | ||
|
|
@@ -70,3 +70,6 @@ jobs: | |
| run: gh pr merge --auto --squash "${{ steps.cpr.outputs.pull-request-number }}" | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| defaults: | ||
| run: | ||
| working-directory: apps/cli-go | ||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
Do we use pnpm / bun ? Seems like we use both I guess that's expected could use the context why we don't just use Bun everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude gave me this answer, just double checking it's correct:
Found the file you're looking at — it's
.github/actions/setup/action.yml. Here's what's actually going on:The two tools play different roles, they're not redundant:
pnpm = package/workspace manager. The repo is a pnpm workspace (
pnpm-workspace.yaml,pnpm-lock.yaml,packageManager: pnpm@10.33.0). It's pinned because:catalog:versions (e.g."@swc-node/register": "catalog:"in the rootpackage.json) — a pnpm workspace feature.pnpm-lock.yaml; switching the installer would invalidate reproducibility and CI caching (cache: pnpm).CLAUDE.mdis explicit: "pnpmis the package manager. Usepnpm <script>. Do not usebun runornpm run."Bun = TypeScript runtime for executing scripts/tests. It's not used to install deps. It's needed because:
@tsconfig/bun/tsconfig.jsonand pull in@types/bun— code is written against Bun's runtime/types."local-registry": "bun tools/release/local-registry.ts"and"cli-release": "bun tools/release/local-release.ts"— running.tswithout a build step.@effect/vitestwithit.live, and the harness expects the Bun runtime to be present.So: pnpm owns dependency graph + workspace plumbing + lockfile; Bun owns "execute TypeScript directly." Going bun-only would mean migrating the lockfile, dropping pnpm catalogs, and rewriting workspace tooling — a much bigger change than the consolidation PR is doing. It's a deliberate split, not an oversight.