fix: set a fallback redirectUri for external provider#5165
Open
singh-inder wants to merge 3 commits intosupabase:developfrom
Open
fix: set a fallback redirectUri for external provider#5165singh-inder wants to merge 3 commits intosupabase:developfrom
singh-inder wants to merge 3 commits intosupabase:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
After #5092, cli no longer sets a default redirectUri for external providers when not defined in config.toml. Also, config file mentions there will be a default redirectUri set if not provided.
cli/pkg/config/templates/config.toml
Lines 322 to 323 in 893c284
What is the new behavior?
set default redirectUri to
Auth.JwtIssuer/callbackif not provided