fix: prepend mailer_urlpaths with JwtIssuer#5164
Closed
singh-inder wants to merge 2 commits intosupabase:developfrom
Closed
fix: prepend mailer_urlpaths with JwtIssuer#5164singh-inder wants to merge 2 commits intosupabase:developfrom
singh-inder wants to merge 2 commits intosupabase:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix #5163
What is the new behavior?
prepend
GOTRUE_MAILER_URLPATHS_<flow>env withAuth.JwtIssuerurl. Safe to use full url in path env as supabase auth constructs the final email link usingexternalURL.ResolveReference(path).String()for all mailer paths https://github.com/supabase/auth/blob/be317c1a37aba9bc7d0c6664f476f446bfecb942/internal/mailer/templatemailer/templatemailer.go#L365