fix: add StartPeriod to storage container health check#4956
Open
zlotnika wants to merge 1 commit intosupabase:developfrom
Open
fix: add StartPeriod to storage container health check#4956zlotnika wants to merge 1 commit intosupabase:developfrom
zlotnika wants to merge 1 commit intosupabase:developfrom
Conversation
…failures Storage-api v1.41.8 added a DB connection pool monitor that can delay readiness on startup. Without a StartPeriod, Docker begins counting health check failures immediately, causing the container to be marked unhealthy before it has time to fully initialize (~50% failure rate on ARM CI runners). Adding StartPeriod: 10s gives the storage container a grace window before Docker starts counting failures, matching the pattern already used by Logflare and Mailpit containers. Fixes supabase#4941
Pull Request Test Coverage Report for Build 23115482145Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4941
StartPeriod: 10 * time.Secondto the storage container's Docker health check configWhy
Storage-api v1.41.8 (bumped in #4935) added a DB connection pool monitor (
startMonitor) that can delay readiness on startup. Without aStartPeriod, Docker begins counting health check failures immediately from container start. With 10s intervals and 3 retries, the container can be markedunhealthywithin ~30s — before the pool monitor finishes initializing. This causes ~50% failure rate on ARM CI runners.How
StartPeriodtells Docker to ignore health check failures during the initial grace window. This is the same pattern already used by Logflare and Mailpit containers in this codebase. During the 10s start period, failed health checks don't count toward the retry limit, giving storage time to fully initialize before Docker starts tracking failures.