Skip to content

fix: clarify error message when starting docker container#4790

Open
unlair wants to merge 1 commit intosupabase:developfrom
unlair:fix/indicate-which-container-failed-in-error-msg
Open

fix: clarify error message when starting docker container#4790
unlair wants to merge 1 commit intosupabase:developfrom
unlair:fix/indicate-which-container-failed-in-error-msg

Conversation

@unlair
Copy link

@unlair unlair commented Feb 2, 2026

Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.

What kind of change does this PR introduce?

Bug fix (updating error message).

What is the current behavior?

When an error is returned when starting a Docker container (e.g. #3593 the error message reads:
failed to start docker container: <some error>

What is the new behavior?

The error message reads:
failed to start docker container "<container name>": <some error>

@unlair unlair requested a review from a team as a code owner February 2, 2026 22:31
@unlair unlair force-pushed the fix/indicate-which-container-failed-in-error-msg branch from 3c3b4c0 to 42266b4 Compare February 4, 2026 16:56
@coveralls
Copy link

coveralls commented Feb 4, 2026

Pull Request Test Coverage Report for Build 23117237283

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 61.713%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 80.61%
internal/utils/git.go 5 57.14%
Totals Coverage Status
Change from base Build 23067059123: -0.02%
Covered Lines: 7719
Relevant Lines: 12508

💛 - Coveralls

@unlair unlair force-pushed the fix/indicate-which-container-failed-in-error-msg branch from 42266b4 to 97f8bfd Compare February 15, 2026 04:19
@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9b7d3199-edc9-42c8-82c3-21d48ae2b234

📥 Commits

Reviewing files that changed from the base of the PR and between ab6464d and e1e0505.

📒 Files selected for processing (1)
  • internal/utils/docker.go

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Docker container startup error messages now include the container name to make failures easier to identify and troubleshoot. No functional behavior changed.

Walkthrough

The DockerStart function's error handling was modified to include the container name in the wrapped error message. The format string changed from "failed to start docker container: %w" to "failed to start docker container %q: %w", containerName, err. No other logic, control flow, or public signatures were changed.

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: clarifying an error message when docker container startup fails by adding the container name.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into develop

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@unlair unlair force-pushed the fix/indicate-which-container-failed-in-error-msg branch from 97f8bfd to ab6464d Compare February 28, 2026 01:48
@unlair unlair force-pushed the fix/indicate-which-container-failed-in-error-msg branch from ab6464d to e1e0505 Compare March 9, 2026 22:35
Error message was not indicating which Docker container failed to start, forcing the user to use a process of elimination to narrow down the problem.
@unlair unlair force-pushed the fix/indicate-which-container-failed-in-error-msg branch from e1e0505 to a0c7e8e Compare March 15, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants