🐞 Fix spm install syntax and remove code analysis - #20
Conversation
…nces - Use full GitHub URL format for spm install commands - Add tooling-to-package mapping table in init.md Step 2 - Remove Code analysis / SonarQube from init, setup, and audit - Clarify review-resolve to reference automated PR reviewers Closes #19
There was a problem hiding this comment.
Pull request overview
Updates Arcana’s project onboarding/setup documentation to use the correct spm install URL format for skillbox skills and to remove SonarQube/“code analysis” as an Arcana-detected/required component (since it’s CI-side tooling).
Changes:
- Fixes Arcana documentation to use
spm install https://github.com/supa-magic/skillbox/tree/main/skills/{skill}. - Adds a detected-tool → skillbox package mapping table in
init.mdStep 2. - Removes SonarQube/code-analysis references from project setup/audit flows and adjusts review-resolve wording.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/arcana/skills/arc-project/setup.md | Removes “Code analysis / SonarQube” from the recommended tooling catalog and updates the documented spm install syntax. |
| skills/arcana/skills/arc-project/init.md | Removes code-analysis detection from Step 1 output and adds a tooling→skillbox install mapping table for Step 2. |
| skills/arcana/skills/arc-project/audit.md | Removes the “code-analyze / sonarqube” line from the audit example output. |
| skills/arcana/skills/arc-code/review-resolve.md | Updates the gather-context step to reference automated review comments rather than code analysis reports. |
| **Confirmation gate:** If `-y` → install all. Otherwise → show list and ask: "Install these skills?" Wait for confirmation. | ||
| | Detected Tool | Skillbox Package | Install Command | | ||
| |---------------|-----------------|-----------------| | ||
| | GitHub (git hosting) | `git` | `spm install https://github.com/supa-magic/skillbox/tree/main/skills/git` | |
There was a problem hiding this comment.
In the Step 2 mapping table, GitHub (git hosting) is mapped to the git skillbox package. However, other Arcana docs treat GitHub PR/hosting operations as the github skill (e.g., arc-code/review-request.md and arc-code/review-resolve.md both suggest installing .../skills/github for PR workflows). This mapping likely causes the init flow to offer the wrong package for the required “Git hosting skill”. Consider mapping GitHub (git hosting) to github as well (or explicitly explain why git is sufficient for hosting/PR operations and update the other docs accordingly).
| | GitHub (git hosting) | `git` | `spm install https://github.com/supa-magic/skillbox/tree/main/skills/git` | | |
| | GitHub (git hosting) | `github` | `spm install https://github.com/supa-magic/skillbox/tree/main/skills/github` | |
| 1. Read `.arcana/project-context.md` for conventions | ||
| 2. Fetch PR comments and review status using the appropriate skill or MCP tool | ||
| 3. Fetch code analysis reports if available (via appropriate skills configured in `project-context.md`) | ||
| 3. Fetch automated review comments if available (e.g., Copilot, linter bots) | ||
| 4. Read AC files for the ticket (for context when classifying comments) |
There was a problem hiding this comment.
Step 3 was updated to say “Fetch automated review comments”, but this document still refers to “code analysis tools” (line 5) and has an “Automated review (code analysis tool)” example later on. To match the PR goal of removing CI-style “code analysis” references, consider updating the remaining wording/examples to use the same “automated reviewers / automated review comments” terminology throughout.
Description
Fix incorrect spm install command syntax in arcana project init/setup skills and remove references to Code analysis (SonarQube) which is a CI-side tool, not an Arcana skill.
Type of change
Related Issues
Notes
spm install https://github.com/supa-magic/skillbox/tree/main/skills/{skill}Check list