Repository navigation
Make strict assertion failures and single operand evaluation canonical - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHECK comparisons evaluated operands twice, and assertions thrown by context-free helpers could be caught without failing the enclosing test or subcase. Evaluate comparison operands once and count uncaught helper assertions. Add the opt-in ZEROERR_CHECK_AS_ERROR policy while preserving warning-only CHECK behavior by default.
Validated with the full Debug CTest suite (10/10), standalone strict/legacy exit-code probes, and Release + LTO probes. EVEngine PR #646 consumes this canonical implementation instead of shadow headers or generated replacement sources.