fix: scope warning suppression and keep consumer macros clean - #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent EVEngine CI emitted 4,306 unknown-warning-group diagnostics per run from zeroerr, plus MSVC macro-shadowing and CRT deprecation noise. Check Clang warning-group support before suppressing it and balance the variadic diagnostic push/pop so suppression cannot leak into consumer code.
Rename the context macro's internal loop variable, scope CRT deprecation suppression to the logging implementation, and remove an unused callback parameter name. Fix GCC-invalid pragma placement in fuzz-test and subcase macros. Regenerate the single header and add compiler regressions, including expected failures that ensure consumer diagnostics remain enabled. Enable the existing workflow for
devPRs.Validation:
devrevision on macro variable shadowing.6443348d0eed: final Windows Debug build with the native test plugin, followed by all 3,902 default process-isolated CTest entries passing in 252 seconds. The first run exposed missing local test prerequisites; both were supplied and the entire suite rerun successfully. Local prebuilt dependencies were reused after verifying identical source Git trees.This does not suppress the serialization memory-operation warnings or warnings that expose unimplemented serialization/logging behavior.