Migrate network clients to new unified Scraper format (Fix #113)#142
Migrate network clients to new unified Scraper format (Fix #113)#142samaloney merged 11 commits intosunpy:mainfrom
Conversation
|
All the CI Checks are green now. The PR is ready for review now @samaloney. |
|
This is not specific to this PR. I'm posting this to all open PRs. Please be aware of the update to our AI usage policy, specifically on the disclosure of and acceptable uses of AI. |
samaloney
left a comment
There was a problem hiding this comment.
Thanks for the PR this looks pretty good, almost ready. This needs to come with a deprecation changelog and an update to project.toml as this code won't work with old version of sunpy
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: codespell | ||
| args: [ "--write-changes" ] | ||
| exclude: "^(check_scraper|reproduce_|test_issue_|prototype_slicing|test_prototype).*\\.py$" |
There was a problem hiding this comment.
Are these local files if so it would be better to remove them locally than change this config?
There was a problem hiding this comment.
Yes, those were local files I accidentally committed. I’ll remove them from the PR and revert the .pre-commit-config.yaml.
|
@samaloney, I have made the suggested changes. All the CI checks are green now. Thanks for the response. Let me know if any more changes are required. |
samaloney
left a comment
There was a problem hiding this comment.
Great, LGTM thanks for your contribution!
PR Description
Migrate network clients to unified Scraper format. Fixes: #113
Summary
This PR updates all
radiospectranetwork clients (RSTN, eCallisto, I-LOFAR, and PSP) to use the modern, unifiedsunpy.net.scraper.Scraperinterface introduced in SunPy 6.1 and enforced in 7.1.0.It fixes CI failures caused by breaking changes in SunPy 7.1.0 and brings the networking code in line with current SunPy standards. This PR restores compatibility and modernizes the implementation to match current SunPy expectations.
What changed
baseurl+patternusage with a single modernpatternstring using the{{ }}format required byScraper.Scraper’s internal.format()handling.KeyErrorby aligning pattern capture groups with metadata usage.search()andpre_search_hook()implementations to match the updatedScraperAPI.Verification
test_ecallisto_client✅test_rstn_client✅test_ilofar✅test_psp_client✅Reviewer:
@samaloney, Please let me know if this change looks good to you or if you’d like any revisions.