Update FavMac - #1219
Open
lehendo wants to merge 1 commit into
Open
Conversation
…ation Independently re-verified FavMac's two threshold formulas directly against Lin, Trivedi, Xiao, and Sun, "Fast Online Value-Maximizing Prediction Sets with Conformal Cost Control" (ICML 2023, arXiv:2302.00839): - Expected cost control: derived target_cost*(n+1) - C_max fresh from the paper's Eq. 18, confirmed exact. This branch adds the missing citation/explanation for this branch (favscrib only documented the violation-control branch's "-1" term). - Violation control: re-derived the "-1" term fresh from Eq. 21, independently confirming favscrib's existing resolution is correct. No new bug found in the core algorithm. Added: - The exchangeability/no-distribution-shift caveat to the public FavMac docstring, consistent with CovariateLabel/NeighborhoodLabel/SCRIB. - Input validation for target_cost > 0, delta in (0,1), and target_cost <= C_max (per the paper's c in (0, C_max] requirement) -- previously unchecked, so invalid inputs would silently produce nonsensical thresholds instead of a clear error. Verified: the internal engine's docstring doctest passes for real (13/13), the expected-cost formula matches a direct re-derivation exactly, and the new validation correctly accepts/rejects inputs. Deliberately scoped to avoid touching the same lines already fixed on favscrib, so the two branches merge independently.
Contributor
|
looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: