Fix broken example scripts and fairness metrics import - #1200
Merged
Conversation
lehendo
commented
Aug 25, 2026
lehendo
commented
Collaborator
- Re-enable fairness_metrics_fn import in pyhealth.metrics (was commented out); add it to all
- Fix SyntaxError in examples/benchmark_perf/loc/minimal_los.py from a concatenated def/class statement
- Fix readmission_mimic3_fairness.py: add missing main guard (was hanging under multiprocessing), update Transformer(...) call to the current dataset-only constructor API, and fix the wrong label key
- Fix sensitive_attributes_from_patient_ids to use the current get_patient()/event-based demographics API instead of the removed dataset.patients attribute; add a verified doctest
- Re-enable fairness_metrics_fn import in pyhealth.metrics (was commented out); add it to __all__. - Fix SyntaxError in examples/benchmark_perf/loc/minimal_los.py from a concatenated def/class statement. - Fix readmission_mimic3_fairness.py: add missing __main__ guard (was hanging under multiprocessing), update Transformer(...) call to the current dataset-only constructor API, and fix the wrong label key. - Fix sensitive_attributes_from_patient_ids to use the current get_patient()/event-based demographics API instead of the removed dataset.patients attribute; add a verified doctest.
lehendo
commented
Aug 30, 2026
lehendo
left a comment
lehendo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looks good to me.
Contributor
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.