♿(frontend) hide decorative emojis in document titles from SR#2527
♿(frontend) hide decorative emojis in document titles from SR#2527Ovgodd wants to merge 1 commit into
Conversation
…ders Mark UI title emojis as aria-hidden while keeping accessible text labels.
cb49502 to
6a6e8f0
Compare
WalkthroughDocument title components now separate decorative emojis from readable titles and render emojis with Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx`:
- Around line 41-44: The shared getEmojiAndTitle helper must remove the entire
contiguous leading emoji prefix, not just match[0], so titles such as “😀🚀
Design” produce “Design” without leaking subsequent emojis. Update
getEmojiAndTitle at the root cause; the affected usages require no direct
changes in
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx:41-44,
src/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsx:47-48,
src/frontend/apps/impress/src/features/docs/doc-header/components/DocLeftPanelCollapseButton.tsx:84-87,
and
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx:189-190
and 310-310.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 228e5ad9-3f72-491e-b6c2-46f9e3bc21b2
📒 Files selected for processing (6)
CHANGELOG.mdsrc/frontend/apps/impress/src/features/docs/doc-header/components/DocLeftPanelCollapseButton.tsxsrc/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsxsrc/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsxsrc/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsxsrc/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx
|
Size Change: +1 B (0%) Total Size: 4.37 MB 📦 View Changed
|
Purpose
This PR hides title emojis from assistive technologies in the application UI while keeping accessible text labels.
issue 2315
Proposal
aria-hidden="true"in the left panel tree (SimpleDocItem,DocSubPageItem)DocTitleText)aria-labeluses text onlyaria-labelvalues