Skip to content

♿(frontend) hide decorative emojis in document titles from SR#2527

Open
Ovgodd wants to merge 1 commit into
mainfrom
a11y/doc-title-decorative-emojis
Open

♿(frontend) hide decorative emojis in document titles from SR#2527
Ovgodd wants to merge 1 commit into
mainfrom
a11y/doc-title-decorative-emojis

Conversation

@Ovgodd

@Ovgodd Ovgodd commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Purpose

This PR hides title emojis from assistive technologies in the application UI while keeping accessible text labels.

issue 2315

Proposal

  • Mark title emojis as aria-hidden="true" in the left panel tree (SimpleDocItem, DocSubPageItem)
  • Mark title emojis as decorative in the document header read-only title (DocTitleText)
  • Pass emoji separately in the left panel collapse button so aria-label uses text only
  • Use title without emoji in tree item aria-label values
  • Leave document body emojis unchanged (user content)
  • Manual SR check: tree items, header title, and collapse button announce text without emoji description

@Ovgodd
Ovgodd requested a review from AntoLC July 15, 2026 10:10
@Ovgodd Ovgodd self-assigned this Jul 15, 2026
@Ovgodd Ovgodd added the feature add a new feature label Jul 15, 2026
@Ovgodd Ovgodd changed the title ♿(frontend) hide decorative emojis in document titles from screen rea… ♿(frontend) hide decorative emojis in document titles from SR Jul 15, 2026
…ders

Mark UI title emojis as aria-hidden while keeping accessible text labels.
@Ovgodd
Ovgodd force-pushed the a11y/doc-title-decorative-emojis branch from cb49502 to 6a6e8f0 Compare July 15, 2026 10:11
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Jul 15, 2026
@Ovgodd
Ovgodd marked this pull request as ready for review July 15, 2026 10:11
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Document title components now separate decorative emojis from readable titles and render emojis with aria-hidden. Collapsed-panel buttons receive title and emoji separately, while document tree accessibility labels use emoji-free display titles. The changelog records the accessibility change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: antolc

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: hiding decorative emojis in document titles from screen readers.
Description check ✅ Passed The description accurately describes the accessibility-focused emoji handling changes in the PR.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch a11y/doc-title-decorative-emojis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx`:
- Around line 41-44: The shared getEmojiAndTitle helper must remove the entire
contiguous leading emoji prefix, not just match[0], so titles such as “😀🚀
Design” produce “Design” without leaking subsequent emojis. Update
getEmojiAndTitle at the root cause; the affected usages require no direct
changes in
src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx:41-44,
src/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsx:47-48,
src/frontend/apps/impress/src/features/docs/doc-header/components/DocLeftPanelCollapseButton.tsx:84-87,
and
src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx:189-190
and 310-310.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 228e5ad9-3f72-491e-b6c2-46f9e3bc21b2

📥 Commits

Reviewing files that changed from the base of the PR and between 8d2dd5b and 6a6e8f0.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/docs/doc-header/components/DocLeftPanelCollapseButton.tsx
  • src/frontend/apps/impress/src/features/docs/doc-header/components/DocTitle.tsx
  • src/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsx
  • src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx
  • src/frontend/apps/impress/src/features/left-panel/components/LeftPanelCollapseButton.tsx

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Size Change: +1 B (0%)

Total Size: 4.37 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/5cdc10ff/_buildManifest.js 697 B +697 B (new file) 🆕
apps/impress/out/_next/static/373157ec/_buildManifest.js 0 B -696 B (removed) 🏆

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

1 participant