Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/substrait/simple_extension_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ def build_type_variation(d: dict) -> se.TypeVariation:
def build_simple_extensions(d: dict) -> se.SimpleExtensions:
return se.SimpleExtensions(
urn=d["urn"],
metadata=d.get("metadata"),
dependencies=d.get("dependencies"),
types=[build_type_model(t) for t in d["types"]] if "types" in d else None,
type_variations=[build_type_variation(t) for t in d["type_variations"]]
Expand Down
51 changes: 51 additions & 0 deletions tests/test_simple_extension_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
"""Tests for parsing simple extension YAML dicts into schema objects."""

from substrait.simple_extension_utils import build_simple_extensions


def test_metadata_is_exposed_at_all_levels():
"""Metadata should be carried through from the YAML dict at every level
where the simple-extension schema supports it (file, function, type)."""
definitions = {
"urn": "extension:test:metadata",
"metadata": {"author": "me", "version": 1},
"types": [
{"name": "point", "metadata": {"kind": "geometry"}},
],
"scalar_functions": [
{
"name": "f",
"impls": [{"return": "i64"}],
"metadata": {"category": "math"},
},
],
"aggregate_functions": [
{
"name": "g",
"impls": [{"return": "i64"}],
"metadata": {"category": "stats"},
},
],
"window_functions": [
{
"name": "h",
"impls": [{"return": "i64"}],
"metadata": {"category": "window"},
},
],
}

extensions = build_simple_extensions(definitions)

assert extensions.metadata == {"author": "me", "version": 1}
assert extensions.types[0].metadata == {"kind": "geometry"}
assert extensions.scalar_functions[0].metadata == {"category": "math"}
assert extensions.aggregate_functions[0].metadata == {"category": "stats"}
assert extensions.window_functions[0].metadata == {"category": "window"}


def test_metadata_defaults_to_none_when_absent():
"""Metadata is optional and should default to None when not present."""
extensions = build_simple_extensions({"urn": "extension:test:no-metadata"})

assert extensions.metadata is None
Loading