feat: advanced_extensions #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
mbwhite
force-pushed
the
advanced_extensions
branch
2 times, most recently
from
4431d73 to
2a7e64a
Compare
Contributor
Author
|
Sorry - used Python 3.10+ syntax initially. |
Contributor
|
3.9 has already reached EOL this month so you were technically correct to use 3.10+ syntax 😆 we should probably drop 3.9 from the tests and add 3.14 instead |
Member
|
@mbwhite can you rebase and resolve the conflicts? thanks |
Add support to the builders for suppling an (optional) advanced extension. Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
advanced_extensions
branch
from
2a7e64a to
d07a441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to pass in an 'advanced extension' to the relation builders.
Optional, but useful if needed.
Improves the level of function compared to the other libraries