[artifactor-cleanup] new helm chart to cleanup Artifactory#272
Open
DanielRaapDev wants to merge 13 commits intomainfrom
Open
[artifactor-cleanup] new helm chart to cleanup Artifactory#272DanielRaapDev wants to merge 13 commits intomainfrom
DanielRaapDev wants to merge 13 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Helm chart (charts/artifactory-cleanup) intended to run the devopshq/artifactory-cleanup tool as a Kubernetes CronJob for periodic Artifactory cleanup (per SUDO-582).
Changes:
- Introduces a new Helm chart with templates for CronJob, ConfigMap, and ServiceAccount.
- Adds default values plus a
test-values.yamlexample and Helm-unittest test suites for default/custom rendering. - Adds chart metadata (
Chart.yaml) and.helmignore.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/artifactory-cleanup/Chart.yaml | New chart metadata for the artifactory-cleanup CronJob chart. |
| charts/artifactory-cleanup/.helmignore | Standard Helm packaging ignore patterns. |
| charts/artifactory-cleanup/values.yaml | Default values for scheduling, credentials, job settings, and pod config. |
| charts/artifactory-cleanup/templates/_helpers.tpl | Helper templates for naming/labels/service account/configmap naming. |
| charts/artifactory-cleanup/templates/configmap.yaml | ConfigMap template to render the cleanup configuration YAML. |
| charts/artifactory-cleanup/templates/serviceaccount.yaml | Optional ServiceAccount creation for the CronJob. |
| charts/artifactory-cleanup/templates/cronjob.yaml | CronJob template to run the cleanup container on a schedule. |
| charts/artifactory-cleanup/test-values.yaml | Example values used by unit tests. |
| charts/artifactory-cleanup/tests/default_values_test.yaml | Helm-unittest suite asserting default rendering. |
| charts/artifactory-cleanup/tests/custom_values_test.yaml | Helm-unittest suite asserting overrides and custom rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…econds, add tests for optional job values
…r or OnFailure; omitting it defaults to Always and is rejected by the Kubernetes API."
…factory-cleanup.fullname" . }}, [...] his will fail at runtime because the referenced ConfigMap doesn't exist."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses https://github.com/devopshq/artifactory-cleanup
SUDO-582