-
Notifications
You must be signed in to change notification settings - Fork 20
Feat/agent #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/agent #874
Changes from all commits
6a81348
6a2105d
ace0e2d
3e47170
f9da56b
4f89286
9b3b5b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,5 @@ VITE_NETWORK=mainnet | |
| VITE_GQL_PROXY=https://gql-proxy.subquery.network | ||
| VITE_NETWORK_DEPLOYMENT_ID=QmQqqmwwaBben8ncfHo3DMnDxyWFk5QcEdTmbevzKj7DBd | ||
| VITE_PROXYGATEWAY=https://gateway.subquery.network | ||
| VITE_SUBQUERY_OFFICIAL_BASE_RPC=https://base.rpc.subquery.network/public | ||
| VITE_SUBQUERY_OFFICIAL_ETH_RPC=https://ethereum.rpc.subquery.network/public | ||
| VITE_USE_SCANNER=1 | ||
| VITE_GRAPHQL_AGENT=https://graphql-agent.subquery.network | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify that removed RPC environment variables are not referenced elsewhere. The variables VITE_SUBQUERY_OFFICIAL_BASE_RPC and VITE_SUBQUERY_OFFICIAL_ETH_RPC were removed from this environment file. However, 🏁 Script executed: #!/bin/bash
# Search for references to the removed environment variables
rg -n 'VITE_SUBQUERY_OFFICIAL_(BASE_RPC|ETH_RPC)' --type ts --type tsx -C 3Length of output: 27 I need to retry the search with a corrected command. Let me search for these environment variable references using a different approach: Length of output: 2642 🏁 Script executed: #!/bin/bash
# Also search directly in the hooks directory to be thorough
rg -n 'VITE_SUBQUERY_OFFICIAL' src/hooks/ -C 3Length of output: 1412 🏁 Script executed: #!/bin/bash
# Check if the specific file exists and examine it
if [ -f "src/hooks/useSpaceId.tsx" ]; then
echo "=== File exists. Examining lines around 20-30 and 45-55 ==="
sed -n '15,35p' src/hooks/useSpaceId.tsx | cat -n
echo ""
sed -n '40,60p' src/hooks/useSpaceId.tsx | cat -n
else
echo "File src/hooks/useSpaceId.tsx not found"
fiLength of output: 1726 Remove references to deleted environment variables or restore them to .env.staging. The removed variables
Removing these without updating all references will result in 🧰 Tools🪛 dotenv-linter (4.0.0)[warning] 11-11: [UnorderedKey] The VITE_GRAPHQL_AGENT key should go before the VITE_IPFS_GATEWAY key (UnorderedKey) |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,7 @@ | |
| "localforage": "^1.10.0", | ||
| "lodash-es": "^4.17.21", | ||
| "lru-cache": "^6.0.0", | ||
| "lucide-react": "^0.544.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify the lucide-react version for security and currency. Ensure that version ^0.544.0 is the latest stable release and has no known security vulnerabilities. 🏁 Script executed: #!/bin/bash
# Check for the latest version and any security advisories for lucide-react
# Check npm for latest version
npm view lucide-react version
# Check for security advisories using GitHub CLI
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: NPM, package: "lucide-react") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'Length of output: 57 Update lucide-react to the latest stable release (0.548.0). The specified version 0.544.0 is not the latest stable release; version 0.548.0 is now available on npm. While the caret allows for updates within the minor/patch range, no known security vulnerabilities were found. Consider updating to the latest stable release to benefit from bug fixes and improvements. 🤖 Prompt for AI Agents |
||
| "p-limit": "^4.0.0", | ||
| "p-queue": "^7.3.4", | ||
| "postcss-import": "^15.1.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify environment variable consistency across all environment files.
The
.env.stagingfile removedVITE_SUBQUERY_OFFICIAL_ETH_RPC, butsrc/hooks/useSpaceId.tsxstill references it. Ensure this variable exists in the base.envfile (not shown in the diff) to prevent staging environment failures.🏁 Script executed:
Length of output: 328
Length of output: 229
🏁 Script executed:
Length of output: 3985
🏁 Script executed:
Length of output: 893
🏁 Script executed:
Length of output: 1004
VITE_SUBQUERY_OFFICIAL_ETH_RPC is missing from all environment files but actively used in code.
The concern is valid and critical. The variable
VITE_SUBQUERY_OFFICIAL_ETH_RPCis referenced in four source files:src/hooks/useSpaceId.tsx(lines 23, 49)src/hooks/useEthersProvider.ts(line 62)src/config/rainbowConf.tsx(line 32)However, it is not defined in
.env,.env.staging, or.env.testnet. This will cause runtime errors when the application attempts to accessimport.meta.env.VITE_SUBQUERY_OFFICIAL_ETH_RPCand receivesundefined.Add
VITE_SUBQUERY_OFFICIAL_ETH_RPCto the.envfile (and any environment-specific files where needed), or handle the undefined case in the dependent code.🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 13-13: [UnorderedKey] The VITE_GRAPHQL_AGENT key should go before the VITE_IPFS_GATEWAY key
(UnorderedKey)
🤖 Prompt for AI Agents