Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d1cf7ea
Fix the internal energy of the under-relaxation factor
rois1995 Sep 29, 2026
a59d827
Compute HLLC on moving grids in the frame of the face, fix its Jacobians
rois1995 Sep 29, 2026
b2e8375
Update the reference values of the regression tests from CI
Sep 30, 2026
d875b76
Update the reference files of the gradient regression tests from CI
Sep 30, 2026
459113d
Merge develop into fix_underrelaxation_factor
rois1995 Oct 9, 2026
e323f4c
Merge fix_underrelaxation_factor into fix_hllc_moving_grids
rois1995 Oct 9, 2026
b365479
Merge branch 'develop' into fix_underrelaxation_factor
joshkellyjak Oct 12, 2026
2d0857d
Apply under-relaxation review style suggestions
rois1995 Oct 12, 2026
d2701a8
Merge remote-tracking branch 'origin/fix_underrelaxation_factor' into…
rois1995 Oct 12, 2026
4960dd0
Fix HLLC supersonic Jacobians for reconstructed face enthalpy
rois1995 Oct 12, 2026
211d177
Separate the HLLC Jacobian option and keep verification access private
rois1995 Oct 12, 2026
3062a04
Materialize AD densities in compressible under-relaxation
rois1995 Oct 13, 2026
8b28ba8
Merge under-relaxation AD density lifetime fix from PR 2942
rois1995 Oct 13, 2026
bc5350d
Merge develop into fix_hllc_moving_grids
rois1995 Oct 20, 2026
ab5c080
Update the HLLC wedge references from CI run 39388009966
rois1995 Oct 20, 2026
d1eca26
Merge commit '2dc7b708dcc81fdc86b8e814e8efff0399a8799c' into HEAD
rois1995 Oct 27, 2026
d18cc7a
Merge commit 'e61e2e9674d15b07d8fa1f959588d5e55ad36551' into HEAD
rois1995 Oct 29, 2026
b6ce12d
Merge commit '7048fd35f56d4bf52e586429d6746a36a10255f8' into HEAD
rois1995 Oct 30, 2026
1fd11d2
Merge commit 'f4b67d23deaac22948cc8d2a2c0da3138ae804f6' into HEAD
rois1995 Oct 31, 2026
1aa4951
Clarify HLLC Jacobian naming and tests
rois1995 Oct 31, 2026
e94eaff
Fix HLLC test formatting
rois1995 Nov 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Common/include/CConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,7 @@ class CConfig {
MUSCL_Kappa_Heat, /*!< \brief Blending coefficient for U-MUSCL scheme for the (fvm) heat equation.*/
MUSCL_Kappa_AdjFlow, /*!< \brief Blending coefficient for U-MUSCL scheme for the adj flow equations.*/
MUSCL_Kappa_Species; /*!< \brief Blending coefficient for U-MUSCL scheme for the species equations.*/
bool Use_Exact_HLLC_Jacobians; /*!< \brief Exact HLLC Jacobians with wave speeds held fixed. */
bool Use_Accurate_Jacobians; /*!< \brief Use numerically computed Jacobians for AUSM+up(2) and SLAU(2). */
bool Use_Accurate_Turb_Jacobians; /*!< \brief Use numerically computed Jacobians for standard SA turbulence model. */
bool EulerPersson; /*!< \brief Boolean to determine whether this is an Euler simulation with Persson shock capturing. */
Expand Down Expand Up @@ -4895,6 +4896,9 @@ class CConfig {
*/
bool GetUse_Accurate_Jacobians(void) const { return Use_Accurate_Jacobians; }

/*!\brief Get whether to use exact HLLC Jacobians with wave speeds held fixed. */
bool GetUse_Exact_HLLC_Jacobians(void) const { return Use_Exact_HLLC_Jacobians; }

/*!
* \brief Get whether to "Use Accurate Jacobians" for Standard SA turbulence model.
* \return yes/no.
Expand Down
2 changes: 2 additions & 0 deletions Common/src/CConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,8 @@ void CConfig::SetConfig_Options() {
addDoubleOption("LAX_SENSOR_COEFF", Kappa_1st_Flow, 0.15);
/*!\brief USE_ACCURATE_FLUX_JACOBIANS \n DESCRIPTION: Use numerically computed Jacobians for AUSM+up(2) and SLAU(2) \ingroup Config*/
addBoolOption("USE_ACCURATE_FLUX_JACOBIANS", Use_Accurate_Jacobians, false);
/*!\brief USE_EXACT_HLLC_JACOBIANS \n DESCRIPTION: Exact HLLC Jacobians with wave speeds held fixed \ingroup Config*/
addBoolOption("USE_EXACT_HLLC_JACOBIANS", Use_Exact_HLLC_Jacobians, false);
/*!\brief CENTRAL_JACOBIAN_FIX_FACTOR \n DESCRIPTION: Improve the numerical properties (diagonal dominance) of the global Jacobian matrix, 3 to 4 is "optimum" (central schemes) \ingroup Config*/
addDoubleOption("CENTRAL_JACOBIAN_FIX_FACTOR", Cent_Jac_Fix_Factor, 4.0);
/*!\brief CENTRAL_JACOBIAN_FIX_FACTOR \n DESCRIPTION: Control numerical properties of the global Jacobian matrix using a multiplication factor for incompressible central schemes \ingroup Config*/
Expand Down
8 changes: 8 additions & 0 deletions SU2_CFD/include/numerics/flow/convection/hllc.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
*/
class CUpwHLLC_Flow final : public CNumerics {
private:
friend struct HLLCJacobianTestAccess;
bool implicit, dynamic_grid;
bool useExactJacobian; /*!< \brief Jacobians computed exactly for fixed wave speeds (USE_EXACT_HLLC_JACOBIANS). */
unsigned short iDim, jDim, iVar, jVar;

su2double *IntermediateState;
Expand All @@ -55,6 +57,8 @@ class CUpwHLLC_Flow final : public CNumerics {
su2double *dSm_dU, *dPI_dU, *drhoStar_dU, *dpStar_dU, *dEStar_dU;

su2double* Flux; /*!< \brief The flux accross the face. */
bool fixedWaveSpeeds = false; /*!< \brief Use fixed_sL, fixed_sR as wave speeds (verification of the Jacobians). */
su2double fixed_sL = 0.0, fixed_sR = 0.0;
su2double** Jacobian_i; /*!< \brief The Jacobian w.r.t. point i after computation. */
su2double** Jacobian_j; /*!< \brief The Jacobian w.r.t. point j after computation. */

Expand Down Expand Up @@ -90,7 +94,9 @@ class CUpwHLLC_Flow final : public CNumerics {
*/
class CUpwGeneralHLLC_Flow final : public CNumerics {
private:
friend struct HLLCJacobianTestAccess;
bool implicit, dynamic_grid;
bool useExactJacobian; /*!< \brief Jacobians computed exactly for fixed wave speeds (USE_EXACT_HLLC_JACOBIANS). */
unsigned short iDim, jDim, iVar, jVar;

su2double *IntermediateState;
Expand All @@ -108,6 +114,8 @@ class CUpwGeneralHLLC_Flow final : public CNumerics {
su2double *dSm_dU, *dPI_dU, *drhoStar_dU, *dpStar_dU, *dEStar_dU;

su2double* Flux; /*!< \brief The flux accross the face. */
bool fixedWaveSpeeds = false; /*!< \brief Use fixed_sL, fixed_sR as wave speeds (verification of the Jacobians). */
su2double fixed_sL = 0.0, fixed_sR = 0.0;
su2double** Jacobian_i; /*!< \brief The Jacobian w.r.t. point i after computation. */
su2double** Jacobian_j; /*!< \brief The Jacobian w.r.t. point j after computation. */

Expand Down
Loading
Loading