Skip to content

Avoid recomputing residual norms for MG early exit #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcarruscag wants to merge 12 commits into
base: develop
Choose a base branch
from
+710 −787
Open

Avoid recomputing residual norms for MG early exit #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d1e5d59
cleanup
pcarruscag Apr 12, 2026
62ad49c
fix
pcarruscag Apr 13, 2026
dd8b29f
check that we can recover the current behavior
pcarruscag Apr 13, 2026
31b0421
Revert "check that we can recover the current behavior"
pcarruscag Apr 13, 2026
768b781
fix regressions
bigfooted Apr 13, 2026
6a86303
fix regressions
bigfooted Apr 14, 2026
6e1d9e5
Apply suggestions from code review
bigfooted Apr 14, 2026
cb81b12
Apply suggestions from code review
bigfooted Apr 14, 2026
7b8b7bb
update regression residual
bigfooted Apr 14, 2026
671a0c8
fixed_cl first one
bigfooted Apr 14, 2026
f0b5c20
fix more
bigfooted Apr 14, 2026
953bff9
fix more
bigfooted Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions SU2_CFD/include/integration/ComputeLinSysResRMS.hpp
View file
Open in desktop

This file was deleted.

234 changes: 110 additions & 124 deletions SU2_CFD/src/integration/CMultiGridIntegration.cpp
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SU2_CFD/src/solvers/CSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,7 +1963,7 @@ void CSolver::AdaptCFLNumber(CGeometry **geometry,
void CSolver::SetResidual_RMS(const CGeometry *geometry, const CConfig *config) {
SU2_ZONE_SCOPED

if (geometry->GetMGLevel() != MESH_0) return;
if (geometry->GetMGLevel() != MESH_0 && !config->GetMGOptions().MG_Smooth_EarlyExit) return;
Comment thread
pcarruscag marked this conversation as resolved.

BEGIN_SU2_OMP_SAFE_GLOBAL_ACCESS {

Expand Down
76 changes: 38 additions & 38 deletions TestCases/cont_adj_euler/naca0012/of_grad_cd_disc.dat.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,39 @@
VARIABLES="VARIABLE" , "GRADIENT" , "FINDIFF_STEP"
0 , -7747.74 , 0.001
1 , -10948.1 , 0.001
2 , -8280.46 , 0.001
3 , -3802.21 , 0.001
4 , 658.085 , 0.001
5 , 4392.72 , 0.001
6 , 7268.92 , 0.001
7 , 9422.0 , 0.001
8 , 11077.6 , 0.001
9 , 12447.2 , 0.001
10 , 13660.8 , 0.001
11 , 14713.0 , 0.001
12 , 15397.1 , 0.001
13 , 15179.4 , 0.001
14 , 12887.9 , 0.001
15 , 5922.05 , 0.001
16 , -11571.8 , 0.001
17 , -51702.7 , 0.001
18 , -126889.0 , 0.001
19 , -21493.4 , 0.001
20 , -22571.2 , 0.001
21 , -16492.2 , 0.001
22 , -10533.8 , 0.001
23 , -6901.19 , 0.001
24 , -5763.06 , 0.001
25 , -6449.91 , 0.001
26 , -8061.2 , 0.001
27 , -9790.18 , 0.001
28 , -11077.2 , 0.001
29 , -11650.8 , 0.001
30 , -11500.7 , 0.001
31 , -10793.0 , 0.001
32 , -9652.1 , 0.001
33 , -7555.2 , 0.001
34 , -2031.11 , 0.001
35 , 12735.8 , 0.001
36 , 43905.7 , 0.001
37 , 85428.3 , 0.001
0 , -3129.83 , 0.001
1 , -11358.3 , 0.001
2 , -14484.0 , 0.001
3 , -14330.8 , 0.001
4 , -12608.7 , 0.001
5 , -10550.0 , 0.001
6 , -8889.13 , 0.001
7 , -7943.27 , 0.001
8 , -7729.55 , 0.001
9 , -8089.35 , 0.001
10 , -8803.82 , 0.001
11 , -9689.36 , 0.001
12 , -10673.2 , 0.001
13 , -11870.0 , 0.001
14 , -13689.4 , 0.001
15 , -16954.6 , 0.001
16 , -23081.3 , 0.001
17 , -35877.8 , 0.001
18 , -71117.5 , 0.001
19 , -17877.2 , 0.001
20 , -22149.1 , 0.001
21 , -18300.4 , 0.001
22 , -12702.7 , 0.001
23 , -8337.57 , 0.001
24 , -6019.84 , 0.001
25 , -5270.34 , 0.001
26 , -4986.92 , 0.001
27 , -3951.65 , 0.001
28 , -1206.3 , 0.001
29 , 3646.51 , 0.001
30 , 10149.0 , 0.001
31 , 16714.8 , 0.001
32 , 20678.6 , 0.001
33 , 19464.5 , 0.001
34 , 13560.5 , 0.001
35 , 8716.09 , 0.001
36 , 9495.39 , 0.001
37 , 14681.0 , 0.001
6 changes: 3 additions & 3 deletions TestCases/cont_adj_euler/naca0012/of_grad_directdiff.dat.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VARIABLES="VARIABLE" , "DRAG" , "EFFICIENCY" , "FORCE_X" , "FORCE_Y" , "FORCE_Z" , "LIFT" , "MOMENT_X" , "MOMENT_Y" , "MOMENT_Z" , "SIDEFORCE"
0 , 0.05240962543 , -27.33945591 , 0.08647516198 , -1.560629715 , 0.0 , -1.562144773 , 0.0 , 0.0 , 0.8858124377 , 0.0
1 , 0.2008795877 , -41.40890891 , 0.2463424389 , -2.081341632 , 0.0 , -2.086220261 , 0.0 , 0.0 , 0.737429107 , 0.0
2 , 0.371975273 , -55.04424867 , 0.4271103196 , -2.522745633 , 0.0 , -2.531462651 , 0.0 , 0.0 , 0.4069664819 , 0.0
0 , 0.08545925082 , -29.66992584 , 0.119474273 , -1.557954145 , 0.0 , -1.560189712 , 0.0 , 0.0 , 0.893137395 , 0.0
1 , 0.2201968158 , -43.87838086 , 0.2655030157 , -2.073951675 , 0.0 , -2.079250049 , 0.0 , 0.0 , 0.7622913414 , 0.0
2 , 0.3777725459 , -57.65606719 , 0.4325932101 , -2.508274445 , 0.0 , -2.517114515 , 0.0 , 0.0 , 0.4420784146 , 0.0
10 changes: 5 additions & 5 deletions TestCases/cont_adj_euler/wedge/of_grad_combo.dat.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VARIABLES="VARIABLE" , "GRADIENT" , "FINDIFF_STEP"
0 , 0.00701137 , 0.0001
1 , 0.00485473 , 0.0001
2 , 0.00244467 , 0.0001
3 , 0.000872557 , 0.0001
VARIABLES="VARIABLE" , "GRADIENT" , "FINDIFF_STEP"
0 , 0.00709917 , 0.0001
1 , 0.00484543 , 0.0001
2 , 0.00243268 , 0.0001
3 , 0.000869029 , 0.0001
Loading
Loading